Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266766: Arrays of types that cannot be an annotation member do not yield exceptions #3925

Closed
wants to merge 1 commit into from

Conversation

@raphw
Copy link
Member

@raphw raphw commented May 7, 2021

If a type is changed from a type that can be a member of an annotation which is used in an array, changing it to a type that cannot be an array member will be treated as if the type is an annotation type. As a result, no exception proxy is created and the type is returned as if it was correctly defined.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266766: Arrays of types that cannot be an annotation member do not yield exceptions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3925/head:pull/3925
$ git checkout pull/3925

Update a local copy of the PR:
$ git checkout pull/3925
$ git pull https://git.openjdk.java.net/jdk pull/3925/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3925

View PR using the GUI difftool:
$ git pr show -t 3925

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3925.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 7, 2021

👋 Welcome back winterhalter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2021

@raphw The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label May 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 7, 2021

Webrevs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 4, 2021

@raphw This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@raphw
Copy link
Member Author

@raphw raphw commented Jun 6, 2021

Reopening PR as it is still under review.

@raphw
Copy link
Member Author

@raphw raphw commented Jun 9, 2021

@raphw raphw force-pushed the 8266766 branch 2 times, most recently from 3e3eb03 to c812a4c Jun 9, 2021
jddarcy
jddarcy approved these changes Jun 9, 2021
Copy link
Member

@jddarcy jddarcy left a comment

To aid future maintainers, please add a short summary comment with an outline of what the test is doing before integrating.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@raphw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266766: Arrays of types that cannot be an annotation member do not yield exceptions

Reviewed-by: darcy, jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
  • ab01cb5: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled
  • 1fd8146: 8268461: ARM32: vector intrinsics reaches ShouldNotReachHere

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy, @jbf) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 10, 2021
@raphw
Copy link
Member Author

@raphw raphw commented Jun 10, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@raphw
Your change (at version c812a4c488815296e14f2cabee1a0c1a7fe50861) is now ready to be sponsored by a Committer.

@raphw
Copy link
Member Author

@raphw raphw commented Jun 10, 2021

To aid future maintainers, please add a short summary comment with an outline of what the test is doing before integrating.

I added a comment to the test to explain what is done in it.

@raphw
Copy link
Member Author

@raphw raphw commented Jun 10, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@raphw
Your change (at version b51dafb) is now ready to be sponsored by a Committer.

jbf
jbf approved these changes Jun 10, 2021
@jbf
Copy link
Member

@jbf jbf commented Jun 10, 2021

/sponsor

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed sponsor labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@jbf @raphw Since your change was applied there have been 12 commits pushed to the master branch:

  • d43c8a7: 8268124: Update java.lang to use switch expressions
  • a187fcc: 8238197: JFR: Rework setting and getting EventHandler
  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working
  • e0c0b13: 8268534: some serviceability/jvmti tests should be run in driver mode
  • 92f0b6d: 8268532: several serviceability/attach tests should be run in driver mode
  • 964118f: 8268538: mark hotspot serviceability/logging tests which ignore external VM flags
  • 05090fc: 8268536: mark hotspot serviceability/dcmd tests which ignore external VM flags
  • ae29f9c: 8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode
  • ea19b04: 8268481: Delete JAWT test files for mac
  • f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/78b09ab04929871605abba3026ce9833c6e75789...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0924382.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants