8266189: Remove C1 "IfInstanceOf" instruction

[y1yang0]

Remove IfInstanceOf instruction, it has been there for a long while(13yrs) and not implemented yet.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266189: Remove C1 "IfInstanceOf" instruction

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3935/head:pull/3935
$ git checkout pull/3935

Update a local copy of the PR:
$ git checkout pull/3935
$ git pull https://git.openjdk.java.net/jdk pull/3935/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3935

View PR using the GUI difftool:
$ git pr show -t 3935

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3935.diff

[bridgekeeper]

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kelthuzadx The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (09384231)

[TobiHartmann]

Looks good to me.

[openjdk]

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266189: Remove C1 "IfInstanceOf" instruction

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 9713152: 8262092: vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java SIGSEGV in memmove_ssse3
• 23446f1: 8265128: [REDO] Optimize Vector API slice and unslice operations
• e5d3ee3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 8851cb6: 8266779: Use instead of ZERO_WIDTH_SPACE
• 0cc7833: 8265208: [JEP-356] : SplittableRandom and SplittableGenerators - splits() methods does not throw NullPointerException when source is null
• f78440a: 8266440: Shenandoah: TestReferenceShortcutCycle.java test failed on AArch64
• de78431: 8241502: C2: Migrate x86_64.ad to MacroAssembler
• c8b7447: 8266603: jpackage: Add missing copyright file in Java runtime .deb installers
• c494efc: 8266774: System property values for stdout/err on Windows UTF-8
• 25d99e5: 8266330: itableMethodEntry::initialize() asserts with archived old classes
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/04fad70437a43c0f38fd53414b8eace2eac93509...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[y1yang0]

Thank you Tobias!

/integrate

[openjdk]

@kelthuzadx
Your change (at version 0938423) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

@TobiHartmann @kelthuzadx Since your change was applied there have been 54 commits pushed to the master branch:

• b46086d: 8266874: Clean up C1 canonicalizer for TableSwitch/LookupSwitch
• 97367c0: 8266808: Search label still uses old search field id
• 06d7602: 8261158: JVMState should not be shared between SafePointNodes
• 476994a: 8266531: ZAddress::address() should be removed from SA
• e828a93: 8261395: C1 crash "cannot make java calls from the native compiler"
• 3c47cab: 8261034: improve jcmd GC.class_histogram to support parallel
• ed32e02: 8241187: ToolBox::grep should allow for negative filtering
• cc03734: 8266925: Add a test to verify that hidden class's members are not statically invocable
• 271a0c7: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
• 1a0ff28: 8255035: Update BCEL to Version 6.5.0
• ... and 44 more: https://git.openjdk.java.net/jdk/compare/04fad70437a43c0f38fd53414b8eace2eac93509...master

Your commit was automatically rebased without conflicts.

Pushed as commit 548899d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.