Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268549: Typo in file name in example for -Xlint:processing #3937

Closed
wants to merge 1 commit into from

Conversation

pzygielo
Copy link

@pzygielo pzygielo commented May 8, 2021

Presented class is public, hence it has to be defined in AnnoProc.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268549: Typo in file name in example for -Xlint:processing

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3937/head:pull/3937
$ git checkout pull/3937

Update a local copy of the PR:
$ git checkout pull/3937
$ git pull https://git.openjdk.java.net/jdk pull/3937/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3937

View PR using the GUI difftool:
$ git pr show -t 3937

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3937.diff

@bridgekeeper bridgekeeper bot added the oca label May 8, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 8, 2021

Hi @pzygielo, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pzygielo" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@pzygielo
Copy link
Author

@pzygielo pzygielo commented May 8, 2021

/signed

@openjdk
Copy link

@openjdk openjdk bot commented May 8, 2021

@pzygielo The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label May 8, 2021
@bridgekeeper bridgekeeper bot added the oca-verify label May 8, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 8, 2021

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@pzygielo
Copy link
Author

@pzygielo pzygielo commented May 20, 2021

I'm listed at OCAs submitted prior to 2021 (gh:pzygielo). What else can I do to have OCA confirmed and move it forward?

@bridgekeeper bridgekeeper bot removed oca oca-verify labels May 27, 2021
@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 3, 2021

What can I do to move it forward?

@pzygielo pzygielo changed the title Fix typo in source filename 9070572: Fix typo in source filename Jun 9, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 10, 2021

What can I do to move it forward?

You need to update the PR with the JBS bug ID (9070572 was the temporary incident ID), which is 8268549 -- see JDK-8268549. You also need to make sure that this PR title matches that of the JBS bug.

@pzygielo pzygielo changed the title 9070572: Fix typo in source filename 8268549: Typo in file name in example for -Xlint:processing Jun 10, 2021
@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 10, 2021

Commit message/PR title updated. Also required change of import implemented.

@openjdk openjdk bot added the rfr label Jun 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 10, 2021

@pzygielo For future reference, please do not force-push to a branch once the associated PR is under review. It makes incremental reviews more difficult. If you need to push additional changes, just add new commits. Similarly, if you need to update your branch with additional commits from master, please merge rather than rebase.

@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 10, 2021

do not force-push to a branch once the associated PR is under review.
just add new commits.
merge rather than rebase.

Understood. I'm sorry for the troubles.

@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 11, 2021

Perhaps this change in method name in example could be considered for this bug as well? It's in the same file. I can push additional commit to this branch if accepted.

@lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Jun 11, 2021

@pzygielo Thanks for your contribution. The man documentations, like *.1, are generated from the original Markdown files by using some tools. So we can't directedly revise these *.1 files. Some comments from another example are linked here for you.

This change is somewhat problematic. The nroff man files are generated from Markdown files which are not (yet) open source. Don't ask: long story; we're working on it.

The bottom line is that this change should really be made to the upstream Markdown file. Direct changes to this file are at risk of being overwritten at some point in the future.

Currently, in order to solve this issue, we can report it to the oracle employees and get their help to revise the original files.
Could @kevinrushforth or anyone else from oracle take a look?

I see that the Assignee of this bug is @jonathan-gibbons. Maybe he can give more information and help, too.

@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 11, 2021

@lgxbslgx thanks for checking and linking example. Hope it can be fixed in sources then.

@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 28, 2021

I think there is also chance to fix source for line 2114

The compiler generates this warning when you have a class that has an
annotation, and you use an annotation processor that cannot handle that
type of exception.
as I suppose it shall be type of annotation.

@pzygielo
Copy link
Author

@pzygielo pzygielo commented Jun 28, 2021

Closing with the hope it would be fixed in the source.

@pzygielo pzygielo closed this Jun 28, 2021
@pzygielo pzygielo deleted the typo branch Jun 28, 2021
@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jun 29, 2021

I'll fix the issues upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler rfr
4 participants