New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268549: Typo in file name in example for -Xlint:processing #3937
Conversation
Hi @pzygielo, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pzygielo" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
I'm listed at OCAs submitted prior to 2021 (gh:pzygielo). What else can I do to have OCA confirmed and move it forward? |
What can I do to move it forward? |
You need to update the PR with the JBS bug ID (9070572 was the temporary incident ID), which is |
Commit message/PR title updated. Also required change of import implemented. |
@pzygielo For future reference, please do not force-push to a branch once the associated PR is under review. It makes incremental reviews more difficult. If you need to push additional changes, just add new commits. Similarly, if you need to update your branch with additional commits from master, please merge rather than rebase. |
Understood. I'm sorry for the troubles. |
Perhaps this change in method name in example could be considered for this bug as well? It's in the same file. I can push additional commit to this branch if accepted. |
@pzygielo Thanks for your contribution. The man documentations, like
Currently, in order to solve this issue, we can report it to the oracle employees and get their help to revise the original files. I see that the |
@lgxbslgx thanks for checking and linking example. Hope it can be fixed in sources then. |
I think there is also chance to fix source for line 2114 jdk/src/jdk.compiler/share/man/javac.1 Lines 2112 to 2114 in e9b2c05
|
Closing with the hope it would be fixed in the source. |
I'll fix the issues upstream. |
Presented class is public, hence it has to be defined in AnnoProc.java.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3937/head:pull/3937
$ git checkout pull/3937
Update a local copy of the PR:
$ git checkout pull/3937
$ git pull https://git.openjdk.java.net/jdk pull/3937/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3937
View PR using the GUI difftool:
$ git pr show -t 3937
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3937.diff