8253721: Flag -XX:AVX3Threshold does not accept Zero value

[jatin-bhateja]

AVX3Threshold has been used in various places to enable emitting AVX3 specific instructions in case data size being worked over is greater than 4096 bytes.

However, user is free to set the threshold value to Zero based on his workload.
In such a case a compile time check is enough to trigger generation of AVX3 instructions. In other cases comparison is done at the runtime though JITed comparison instruction.

Patch allows setting AVX3Threshold to a zero value.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253721: Flag -XX:AVX3Threshold does not accept Zero value

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/394/head:pull/394
$ git checkout pull/394

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jatin-bhateja The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jatin-bhateja]

/label add hotspot-compiler-dev

[openjdk]

@jatin-bhateja
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 00: Full (b2d12d7)

[jatin-bhateja]

/reviewer credit @vnkozlov

[openjdk]

@jatin-bhateja
Reviewer kvn successfully credited.

[vnkozlov]

Looks good. Thank you for ding this.

[openjdk]

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253721: Flag -XX:AVX3Threshold does not accept Zero value

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
• ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
• d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
• 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
• 3ed960e: 8253640: Make MEMFLAGS an enum class
• 86491a5: 8253584: Redunant errors for partial member selects
• ebf443a: 8253590: java/foreign tests are still failing on x86_32 after foreign-memaccess integration
• 431338b: 8212107: VMThread issues and cleanup
• 6bddeb7: 8238761: Asynchronous handshakes
• 6d19fe6: 8253763: ParallelObjectIterator should have virtual destructor
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/840aa2b79e6cbf26d1bee5297b12d2a5988ffd7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me.

[jatin-bhateja]

/integrate

[openjdk]

@jatin-bhateja Since your change was applied there have been 33 commits pushed to the master branch:

• 4d9f207: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac
• 1eca634: 8252000: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdb
• a55cde4: 8252002: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdwp
• ffc97ba: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
• 5310d85: 8252937: Correct "no comment" warnings from javadoc in java.math package
• 8df3e72: 8218685: jlink --list-plugins needs to be readable and tidy
• 2fe0a5d: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
• fb20690: 8253637: Update EC removal
• b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
• ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
• ... and 23 more: https://git.openjdk.java.net/jdk/compare/840aa2b79e6cbf26d1bee5297b12d2a5988ffd7b...master

Your commit was automatically rebased without conflicts.

Pushed as commit ac02afe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.