JDK-8266808: Search label still uses old search field id

[hns]

Trivial change to fix value of for attribute in javadoc search label.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266808: Search label still uses old search field id

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3949/head:pull/3949
$ git checkout pull/3949

Update a local copy of the PR:
$ git checkout pull/3949
$ git pull https://git.openjdk.java.net/jdk pull/3949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3949

View PR using the GUI difftool:
$ git pr show -t 3949

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3949.diff

[bridgekeeper]

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hns The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ee23c2b0)

[pavelrappo]

What was that label's intended effect? I'm looking at the API documentation for JDK 16 and that of the mainline and cannot seem to spot any visual difference.

[hns]

What was that label's intended effect? I'm looking at the API documentation for JDK 16 and that of the mainline and cannot seem to spot any visual difference.

There isn't a visual difference. The purpose of associating a label with an input is mostly to improve accessibility and user experience, e.g.:

• A screen reader can read the label when the input field gets the focus.
• Clicking on the label puts the focus on the input field.

[pavelrappo]

I wonder if a more robust fix would be to associate these elements by nesting rather than by id:

<label>
    <input>
</label>

[hns]

I wonder if a more robust fix would be to associate these elements by nesting rather than by id:

<label>
    <input>
</label>

Yes, that would be an option. It would have prevented the current bug, but it's also a structural change that is not as easily made (might affect layout or, even though unlikely, script behaviour).

[openjdk]

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266808: Search label still uses old search field id

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 8468001: 8263452: Javac slow compilation due to algorithmic complexity
• 67cb22a: 8266601: Fix bugs in AddLNode::Ideal transformations
• 18e9d28: 8266676: G1: Remove dead code init_node_id_to_index_map()
• 0e7bdae: 8265062: Remove duplication constant MaxTextureSize
• 10a049e: 8265956: JVM crashes when matching LShiftVB Node
• 9713152: 8262092: vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t001/TestDescription.java SIGSEGV in memmove_ssse3
• 23446f1: 8265128: [REDO] Optimize Vector API slice and unslice operations
• e5d3ee3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 8851cb6: 8266779: Use instead of ZERO_WIDTH_SPACE
• 0cc7833: 8265208: [JEP-356] : SplittableRandom and SplittableGenerators - splits() methods does not throw NullPointerException when source is null
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/9b769550242e8bf6f9e783bf0d6f4a87d0c6376d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hns]

/integrate

[openjdk]

@hns Since your change was applied there have been 48 commits pushed to the master branch:

• 06d7602: 8261158: JVMState should not be shared between SafePointNodes
• 476994a: 8266531: ZAddress::address() should be removed from SA
• e828a93: 8261395: C1 crash "cannot make java calls from the native compiler"
• 3c47cab: 8261034: improve jcmd GC.class_histogram to support parallel
• ed32e02: 8241187: ToolBox::grep should allow for negative filtering
• cc03734: 8266925: Add a test to verify that hidden class's members are not statically invocable
• 271a0c7: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
• 1a0ff28: 8255035: Update BCEL to Version 6.5.0
• 57c6ba6: 8266822: Rename MetaspaceShared::is_old_class to be more explicit about what "old" means
• 616244f: 8266937: Remove Compile::reshape_address
• ... and 38 more: https://git.openjdk.java.net/jdk/compare/9b769550242e8bf6f9e783bf0d6f4a87d0c6376d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 97367c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.