8266857: PipedOutputStream.sink should be volatile

[cushon]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266857: PipedOutputStream.sink should be volatile

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3960/head:pull/3960
$ git checkout pull/3960

Update a local copy of the PR:
$ git checkout pull/3960
$ git pull https://git.openjdk.java.net/jdk pull/3960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3960

View PR using the GUI difftool:
$ git pr show -t 3960

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3960.diff

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (05795385)
• 00: Full (4093362f)

[dfuch]

For correctness (and peace of mind)- we should probably introduce a local variable in all the places where sink is read more than once outside of a synchronized block (the two write and close methods).
I'd suggest simply inserting a first line in each of these methods:

    var sink = this.sink;

This will ensure that there's only one volatile read.

[cushon]

For correctness (and peace of mind)- we should probably introduce a local variable in all the places where sink is read more than once outside of a synchronized block

Done, thanks!

[dfuch]

LGTM!

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266857: PipedOutputStream.sink should be volatile

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1505 new commits pushed to the master branch:

• 381de0c: 8266753: jdk/test/lib/process/ProcTest.java failed with "Exception: Proc abnormal end"
• 2d2cd78: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
• 9c9c47e: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
• 0344e75: 8266794: Remove dead code notify_allocation_jvmti_allocation_event
• 9e6e222: 8266892: avoid maybe-uninitialized gcc warnings on linux s390x
• 6575566: 8266787: Potential overflow of pointer arithmetic in G1ArchiveAllocator
• 8468001: 8263452: Javac slow compilation due to algorithmic complexity
• 67cb22a: 8266601: Fix bugs in AddLNode::Ideal transformations
• 18e9d28: 8266676: G1: Remove dead code init_node_id_to_index_map()
• 0e7bdae: 8265062: Remove duplication constant MaxTextureSize
• ... and 1495 more: https://git.openjdk.java.net/jdk/compare/15196325977254ee73d96bf99be62c520de59af9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cushon]

/integrate

[openjdk]

@cushon Since your change was applied there have been 1505 commits pushed to the master branch:

• 381de0c: 8266753: jdk/test/lib/process/ProcTest.java failed with "Exception: Proc abnormal end"
• 2d2cd78: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
• 9c9c47e: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
• 0344e75: 8266794: Remove dead code notify_allocation_jvmti_allocation_event
• 9e6e222: 8266892: avoid maybe-uninitialized gcc warnings on linux s390x
• 6575566: 8266787: Potential overflow of pointer arithmetic in G1ArchiveAllocator
• 8468001: 8263452: Javac slow compilation due to algorithmic complexity
• 67cb22a: 8266601: Fix bugs in AddLNode::Ideal transformations
• 18e9d28: 8266676: G1: Remove dead code init_node_id_to_index_map()
• 0e7bdae: 8265062: Remove duplication constant MaxTextureSize
• ... and 1495 more: https://git.openjdk.java.net/jdk/compare/15196325977254ee73d96bf99be62c520de59af9...master

Your commit was automatically rebased without conflicts.

Pushed as commit d0daa72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.