8266819: Separate the stop policies from the compile policies completely #3961

lgxbslgx · 2021-05-11T00:43:05Z

Hi all,

This patch removes the compile policies ATTR_ONLY and CHECK_ONLY so that the compile policies can be separated from the stop policies. And some corresponding tests need to be adjusted, too.

Please see JDK-8266819 and the original discussion for more information.

Thank you for taking the time to review.

Best Regards,
-- Guoxiong

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8266819: Separate the stop policies from the compile policies completely

Reviewers

Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3961/head:pull/3961
$ git checkout pull/3961

Update a local copy of the PR:
$ git checkout pull/3961
$ git pull https://git.openjdk.java.net/jdk pull/3961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3961

View PR using the GUI difftool:
$ git pr show -t 3961

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3961.diff

bridgekeeper · 2021-05-11T00:44:10Z

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-05-11T00:46:12Z

@lgxbslgx The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-05-11T00:50:51Z

Webrevs

00: Full (6719e1a4)

mcimadamore

It looks good - note that since this issue changes the set of command line options, it needs a CSR:

https://wiki.openjdk.java.net/display/csr/CSR+FAQs

lgxbslgx · 2021-05-11T13:59:25Z

/csr

openjdk · 2021-05-11T14:00:22Z

@lgxbslgx has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@lgxbslgx please create a CSR request for issue JDK-8266819. This pull request cannot be integrated until the CSR request is approved.

lgxbslgx · 2021-05-11T15:43:00Z

I created the CSR. Please see JDK-8266920.

lgxbslgx · 2021-05-13T00:56:39Z

FYI: The CSR was approved.

mcimadamore

Changes look good

openjdk · 2021-05-13T09:26:33Z

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266819: Separate the stop policies from the compile policies completely

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

a270cbe: 8267043: IntelliJ project doesn't handle generated sources correctly
08a5a5c: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
b50fc5f: 8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.
d215743: 8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh
ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
... and 47 more: https://git.openjdk.java.net/jdk/compare/5d761fcffd6eea1c5be35d2ddec1479eccb85750...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mcimadamore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

lgxbslgx · 2021-05-13T09:31:43Z

@mcimadamore Thank you for your review. Could I get your help to sponsor this patch?

/integrate

openjdk · 2021-05-13T09:33:25Z

@lgxbslgx
Your change (at version 6719e1a) is now ready to be sponsored by a Committer.

mcimadamore · 2021-05-13T10:20:14Z

/sponsor

openjdk · 2021-05-13T10:22:37Z

@mcimadamore @lgxbslgx Since your change was applied there have been 57 commits pushed to the master branch:

a270cbe: 8267043: IntelliJ project doesn't handle generated sources correctly
08a5a5c: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
b50fc5f: 8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.
d215743: 8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh
ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
... and 47 more: https://git.openjdk.java.net/jdk/compare/5d761fcffd6eea1c5be35d2ddec1479eccb85750...master

Your commit was automatically rebased without conflicts.

Pushed as commit 17ceef9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mlbridge · 2021-05-14T18:34:36Z

Mailing list message from Maurizio Cimadamore on compiler-dev:

I've added a description re. compatibility risk, and also added myself
as reviewer. You can finalize.

Also, please use the `/csr` PR command on github, which will link the PR
to the CSR.

Thanks
Maurizio

On 11/05/2021 16:45, Guoxiong Li wrote:

mlbridge · 2021-05-14T18:34:41Z

Mailing list message from Maurizio Cimadamore on compiler-dev:

I've added a description re. compatibility risk, and also added myself
as reviewer. You can finalize.

Also, please use the `/csr` PR command on github, which will link the PR
to the CSR.

Thanks
Maurizio

On 11/05/2021 16:45, Guoxiong Li wrote:

8266819: Separate the stop policies from the compile policies completely

6719e1a

openjdk bot added the rfr Pull request is ready for review label May 11, 2021

openjdk bot added the compiler compiler-dev@openjdk.org label May 11, 2021

mcimadamore reviewed May 11, 2021

View reviewed changes

openjdk bot added the csr Pull request needs approved CSR before integration label May 11, 2021

openjdk bot removed the csr Pull request needs approved CSR before integration label May 12, 2021

mcimadamore approved these changes May 13, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 13, 2021

openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2021

openjdk bot closed this May 13, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021

lgxbslgx deleted the JDK-8266819 branch May 13, 2021 10:23

8266819: Separate the stop policies from the compile policies completely #3961

8266819: Separate the stop policies from the compile policies completely #3961

lgxbslgx commented May 11, 2021 •

edited by openjdk bot

bridgekeeper bot commented May 11, 2021

openjdk bot commented May 11, 2021

mlbridge bot commented May 11, 2021

mcimadamore left a comment

lgxbslgx commented May 11, 2021

openjdk bot commented May 11, 2021

lgxbslgx commented May 11, 2021

lgxbslgx commented May 13, 2021

mcimadamore left a comment

openjdk bot commented May 13, 2021 •

edited

lgxbslgx commented May 13, 2021

openjdk bot commented May 13, 2021

mcimadamore commented May 13, 2021

openjdk bot commented May 13, 2021

mlbridge bot commented May 14, 2021

mlbridge bot commented May 14, 2021

8266819: Separate the stop policies from the compile policies completely #3961

8266819: Separate the stop policies from the compile policies completely #3961

Conversation

lgxbslgx commented May 11, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented May 11, 2021

openjdk bot commented May 11, 2021

mlbridge bot commented May 11, 2021

Webrevs

mcimadamore left a comment

Choose a reason for hiding this comment

lgxbslgx commented May 11, 2021

openjdk bot commented May 11, 2021

lgxbslgx commented May 11, 2021

lgxbslgx commented May 13, 2021

mcimadamore left a comment

Choose a reason for hiding this comment

openjdk bot commented May 13, 2021 • edited

lgxbslgx commented May 13, 2021

openjdk bot commented May 13, 2021

mcimadamore commented May 13, 2021

openjdk bot commented May 13, 2021

mlbridge bot commented May 14, 2021

mlbridge bot commented May 14, 2021

lgxbslgx commented May 11, 2021 •

edited by openjdk bot

openjdk bot commented May 13, 2021 •

edited