Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266794: Remove dead code notify_allocation_jvmti_allocation_event #3963

Closed
wants to merge 2 commits into from

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented May 11, 2021

This is a trivial change to remove some dead code related to jvmti in gc.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266794: Remove dead code notify_allocation_jvmti_allocation_event

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3963/head:pull/3963
$ git checkout pull/3963

Update a local copy of the PR:
$ git checkout pull/3963
$ git pull https://git.openjdk.java.net/jdk pull/3963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3963

View PR using the GUI difftool:
$ git pr show -t 3963

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3963.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 11, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label May 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 11, 2021

Webrevs

Loading

Copy link
Member

@albertnetymk albertnetymk left a comment

Trivial and LGTM.

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266794: Remove dead code notify_allocation_jvmti_allocation_event

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 67cb22a: 8266601: Fix bugs in AddLNode::Ideal transformations
  • 18e9d28: 8266676: G1: Remove dead code init_node_id_to_index_map()
  • 0e7bdae: 8265062: Remove duplication constant MaxTextureSize
  • 10a049e: 8265956: JVM crashes when matching LShiftVB Node

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 11, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented May 11, 2021

@tschatzl @albertnetymk Thanks for your review.

/integrate

Loading

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@Hamlin-Li Since your change was applied there have been 7 commits pushed to the master branch:

  • 9e6e222: 8266892: avoid maybe-uninitialized gcc warnings on linux s390x
  • 6575566: 8266787: Potential overflow of pointer arithmetic in G1ArchiveAllocator
  • 8468001: 8263452: Javac slow compilation due to algorithmic complexity
  • 67cb22a: 8266601: Fix bugs in AddLNode::Ideal transformations
  • 18e9d28: 8266676: G1: Remove dead code init_node_id_to_index_map()
  • 0e7bdae: 8265062: Remove duplication constant MaxTextureSize
  • 10a049e: 8265956: JVM crashes when matching LShiftVB Node

Your commit was automatically rebased without conflicts.

Pushed as commit 0344e75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@Hamlin-Li Hamlin-Li deleted the remove-jvmti branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants