Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266795: Remove dead code LowMemoryDetectorDisabler #3964

Closed

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented May 11, 2021

This is trivial change to remove dead code in low memory detector.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266795: Remove dead code LowMemoryDetectorDisabler

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3964/head:pull/3964
$ git checkout pull/3964

Update a local copy of the PR:
$ git checkout pull/3964
$ git pull https://git.openjdk.java.net/jdk pull/3964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3964

View PR using the GUI difftool:
$ git pr show -t 3964

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3964.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hamlin,

What you have seems fine, but unless I missed something it seems the whole notion of being enabled/disabled is unused:

// > 0 if temporary disabed
static volatile jint _disabled_count;
static bool temporary_disabled() { return _disabled_count > 0; }
static void disable() { Atomic::inc(&_disabled_count); }
static void enable() { Atomic::dec(&_disabled_count); }

Thanks,
David

@openjdk
Copy link

openjdk bot commented May 11, 2021

⚠️ @Hamlin-Li This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@Hamlin-Li
Copy link
Author

Thanks David for your detailed review. Just updated as you suggested.

@Hamlin-Li
Copy link
Author

Seems the build failure is not related to this change.
'''
2021-05-11T13:21:17.0861973Z Err:27 https://packages.microsoft.com/repos/azure-cli focal Release
2021-05-11T13:21:17.0863392Z Could not wait for server fd - select (11: Resource temporarily unavailable) [IP: 13.82.67.141 443]
2021-05-11T13:21:50.1858001Z Err:28 https://packages.microsoft.com/ubuntu/20.04/prod focal Release
2021-05-11T13:21:50.1859811Z Could not wait for server fd - select (11: Resource temporarily unavailable) [IP: 13.82.67.141 443]
2021-05-11T13:21:56.7524970Z Reading package lists...
2021-05-11T13:21:56.7679502Z E: The repository 'https://packages.microsoft.com/repos/azure-cli focal Release' no longer has a Release file.
2021-05-11T13:21:56.7681552Z E: The repository 'https://packages.microsoft.com/ubuntu/20.04/prod focal Release' no longer has a Release file.
2021-05-11T13:21:56.7697849Z ##[error]Process completed with exit code 100.
'''

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks,
David

@openjdk
Copy link

openjdk bot commented May 13, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266795: Remove dead code LowMemoryDetectorDisabler

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • d215743: 8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh
  • ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
  • 2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
  • accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
  • 69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
  • 7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
  • 4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
  • 11759bf: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion
  • dcf250d: 8233378: CHT: Fast reset
  • f3b510b: 8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/0344e751e2bfd2c6238fc1cea3db19015ce0db88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2021
@Hamlin-Li
Copy link
Author

Thanks David for your detailed review!

/integrate

@openjdk openjdk bot closed this May 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2021
@openjdk
Copy link

openjdk bot commented May 14, 2021

@Hamlin-Li Since your change was applied there have been 53 commits pushed to the master branch:

  • 1e0ecd6: 8265605: Cannot call BootLoader::loadClassOrNull before initPhase2
  • 4086081: 8264846: Regression ~5% in J2dBench.bimg_misc on Linux after JDK-8263142
  • 2a2f105: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
  • 2667024: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • 6c107fd: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles
  • 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
  • f3c6cda: 8266162: Remove JPackage duplicate tests
  • a259ab4: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
  • b4371e9: 8266552: Technical corrections to java/util/random/package-info.java
  • e14b026: 8243287: Removal of Unsafe::defineAnonymousClass
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/0344e751e2bfd2c6238fc1cea3db19015ce0db88...master

Your commit was automatically rebased without conflicts.

Pushed as commit 301095c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the remove-LowMemoryDetectorDisabler branch June 30, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants