Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253636: C2: Adjust NodeClasses::_max_classes #397

Closed
wants to merge 1 commit into from

Conversation

@robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Sep 29, 2020

Update NodeClasses::_max_classes to the max class id within the enumeration. Update comment and assertion to reflect that NodeClasses uses now 32 bits after the addition of Opaque1 in JDK-8229495.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/397/head:pull/397
$ git checkout pull/397

Update NodeClasses::_max_classes to the max class id within the
enumeration. Update comment and assertion to reflect that NodeClasses uses now
32 bits after the addition of Opaque1 in JDK-8229495.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2020

👋 Welcome back robcasloz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@robcasloz The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Sep 29, 2020

/summary
Update NodeClasses::_max_classes to the max class id within the
enumeration. Update comment and assertion to reflect that NodeClasses uses now
32 bits after the addition of Opaque1 in JDK-8229495.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@robcasloz Setting summary to:

Update NodeClasses::_max_classes to the max class id within the
enumeration. Update comment and assertion to reflect that NodeClasses uses now
32 bits after the addition of Opaque1 in JDK-8229495.

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Sep 29, 2020

Tested on hs-tier1-3, both debug and release.

Loading

@robcasloz robcasloz marked this pull request as ready for review Sep 29, 2020
@openjdk openjdk bot added the rfr label Sep 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Webrevs

Loading

Copy link
Contributor

@neliasso neliasso left a comment

Looks good!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253636: C2: Adjust NodeClasses::_max_classes

Update NodeClasses::_max_classes to the max class id within the
enumeration. Update comment and assertion to reflect that NodeClasses uses now
32 bits after the addition of Opaque1 in JDK-8229495.

Reviewed-by: neliasso, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
  • 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
  • ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
  • 092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
  • 06d8cf6: 8253812: Cleanup AbstractMemberWriter
  • 424d7d6: 8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor
  • 2a406f3: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
  • 4b16f8a: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • ... and 54 more: https://git.openjdk.java.net/jdk/compare/fed3636f12b442ee80375025301f137c950625c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@neliasso, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 29, 2020
@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Sep 29, 2020

Looks good!

Thanks for reviewing, Nils.

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Oct 1, 2020

Good.

Thanks Vladimir.

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Oct 1, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Oct 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@robcasloz
Your change (at version 82cacbd) is now ready to be sponsored by a Committer.

Loading

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 1, 2020

/sponsor

Loading

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2020

@TobiHartmann @robcasloz Since your change was applied there have been 64 commits pushed to the master branch:

  • 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
  • 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
  • ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
  • 092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
  • 06d8cf6: 8253812: Cleanup AbstractMemberWriter
  • 424d7d6: 8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor
  • 2a406f3: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
  • 4b16f8a: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • ... and 54 more: https://git.openjdk.java.net/jdk/compare/fed3636f12b442ee80375025301f137c950625c4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5dd9353.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants