New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8266892: avoid maybe-uninitialized gcc warnings on linux s390x #3970
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and trivial. Consider simplifying the comment.
@@ -1387,6 +1387,7 @@ inline unsigned int Assembler::get_instruction(unsigned char *pc, unsigned long | |||
// The length as returned from instr_len() can only be 2, 4, or 6 bytes. | |||
// Having a default clause makes the compiler happy. | |||
ShouldNotReachHere(); | |||
*instr = 0L; // This assignment is there to make gcc8 happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just move the comment to the comment block above:
// Having a default clause and definite assignment makes the compiler happy.
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for fixing.
/integrate |
@MBaesken Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9e6e222. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In the linux s390x hs code there are a few "maybe-uninitialized" gcc warnings with gcc 8 (those warning class is disabled currently in jdk17 but enabled e.g. in jdk11). It would be good to fix them anyway which is done by this small change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3970/head:pull/3970
$ git checkout pull/3970
Update a local copy of the PR:
$ git checkout pull/3970
$ git pull https://git.openjdk.java.net/jdk pull/3970/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3970
View PR using the GUI difftool:
$ git pr show -t 3970
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3970.diff