Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8266892: avoid maybe-uninitialized gcc warnings on linux s390x #3970

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 11, 2021

In the linux s390x hs code there are a few "maybe-uninitialized" gcc warnings with gcc 8 (those warning class is disabled currently in jdk17 but enabled e.g. in jdk11). It would be good to fix them anyway which is done by this small change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266892: avoid maybe-uninitialized gcc warnings on linux s390x

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3970/head:pull/3970
$ git checkout pull/3970

Update a local copy of the PR:
$ git checkout pull/3970
$ git pull https://git.openjdk.java.net/jdk pull/3970/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3970

View PR using the GUI difftool:
$ git pr show -t 3970

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3970.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and trivial. Consider simplifying the comment.

@@ -1387,6 +1387,7 @@ inline unsigned int Assembler::get_instruction(unsigned char *pc, unsigned long
// The length as returned from instr_len() can only be 2, 4, or 6 bytes.
// Having a default clause makes the compiler happy.
ShouldNotReachHere();
*instr = 0L; // This assignment is there to make gcc8 happy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just move the comment to the comment block above:

// Having a default clause and definite assignment makes the compiler happy.

@openjdk
Copy link

openjdk bot commented May 11, 2021

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266892: avoid maybe-uninitialized gcc warnings on linux s390x

Reviewed-by: shade, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2021
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for fixing.

@MBaesken
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@MBaesken Since your change was applied there have been 3 commits pushed to the master branch:

  • 6575566: 8266787: Potential overflow of pointer arithmetic in G1ArchiveAllocator
  • 8468001: 8263452: Javac slow compilation due to algorithmic complexity
  • 67cb22a: 8266601: Fix bugs in AddLNode::Ideal transformations

Your commit was automatically rebased without conflicts.

Pushed as commit 9e6e222.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants