Skip to content

JDK-8266281: Assign Symbols to the package selector expression #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented May 11, 2021

The proposal in this patch is that package names in the package clause would be attributed with the appropriate PackageSymbols. So when using Trees.getElement on an AST node of some part of the package name, a sensible PackageSymbol would be returned.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266281: Assign Symbols to the package selector expression

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3977/head:pull/3977
$ git checkout pull/3977

Update a local copy of the PR:
$ git checkout pull/3977
$ git pull https://git.openjdk.java.net/jdk pull/3977/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3977

View PR using the GUI difftool:
$ git pr show -t 3977

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3977.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Jun 1, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266281: Assign Symbols to the package selector expression

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 486 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2021
@lahodaj
Copy link
Contributor Author

lahodaj commented Jun 2, 2021

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@lahodaj Since your change was applied there have been 504 commits pushed to the master branch:

  • a223189: 8264774: Implementation of Foreign Function and Memory API (Incubator)
  • 71425dd: 8267118: OutOfMemoryError cannot be caught as a Throwable
  • de6472c: 8267459: Pasting Unicode characters into JShell does not work.
  • 9247630: 8265270: Type.getEnclosingType() may fail with CompletionFailure
  • 2d494bf: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries
  • bba3728: 8267726: ZGC: array_copy_requires_gc_barriers too strict
  • d47a77d: 8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly
  • 496fb90: 8267969: Add vectorized implementation for VectorMask.eq()
  • 1cea6ca: 8260360: IGV: Short name of combined nodes is hidden by background color
  • 7530c00: 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type
  • ... and 494 more: https://git.openjdk.java.net/jdk/compare/343a4a76f273078f78897e8fb7e695bc2c111536...master

Your commit was automatically rebased without conflicts.

Pushed as commit 19450b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants