Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8253682: The AppletInitialFocusTest1.java is unstable #398

Closed
wants to merge 1 commit into from
Closed

8253682: The AppletInitialFocusTest1.java is unstable #398

wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 29, 2020 •
edited by openjdk bot

The test assumes that the code below will trigger the focus event on the button2 immediately after setVisible(), but the window can become visible really fast before button2.requestFocus(); is called, so temporarily the button1 will get a focus for a small moment.

    add(button1);
    add(button2);
    setVisible(true);
    button2.requestFocus();

After the fix, the test will wait for the last focus event, and after that, it checks that the correct button is focused.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253682: The AppletInitialFocusTest1.java is unstable

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/398/head:pull/398
$ git checkout pull/398

mrserb
mrserb commented Sep 29, 2020
View reviewed changes
test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
parent = parent.getParent();
}
/*
* This applet is designed to be run only with appletviewer,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the old code assumed that the test is executed via appletviewer as an applet.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mrserb
mrserb commented Sep 29, 2020
View reviewed changes
test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java
}
}
focused = e.getSource();
System.out.println("focused = " + focused);
}

public void focusLost(FocusEvent e) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't fail immediately but wait for some other focus events.

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Sep 29, 2020
@mrserb mrserb marked this pull request as ready for review September 29, 2020 10:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253682: The AppletInitialFocusTest1.java is unstable

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
  • 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
  • 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
  • ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
  • 092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
  • 06d8cf6: 8253812: Cleanup AbstractMemberWriter
  • 424d7d6: 8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor
  • 2a406f3: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/70b0fccf79ac7193b36c49aff0286fdc09bb370c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2020
@mrserb
Copy link
Member Author

mrserb commented Oct 1, 2020

/integrate

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@mrserb Since your change was applied there have been 48 commits pushed to the master branch:

  • 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
  • 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
  • 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
  • 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
  • 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
  • ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
  • 092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
  • 06d8cf6: 8253812: Cleanup AbstractMemberWriter
  • 424d7d6: 8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor
  • 2a406f3: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/70b0fccf79ac7193b36c49aff0286fdc09bb370c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1d88172.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8253682 branch October 1, 2020 08:12
@mrserb mrserb restored the JDK-8253682 branch April 25, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayathirthrao jayathirthrao jayathirthrao approved these changes

Assignees
No one assigned
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
2 participants
@mrserb @jayathirthrao