Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI #3982

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented May 11, 2021

This PR exposes the StackOverflow::_stack_overflow_limit field to JVMCI Java code for use in Graal.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3982/head:pull/3982
$ git checkout pull/3982

Update a local copy of the PR:
$ git checkout pull/3982
$ git pull https://git.openjdk.java.net/jdk pull/3982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3982

View PR using the GUI difftool:
$ git pr show -t 3982

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3982.diff

@dougxc dougxc marked this pull request as ready for review May 11, 2021 15:47
@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk
Copy link

openjdk bot commented May 11, 2021

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 1356116: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation
  • dfe8833: 8266783: java/lang/reflect/Proxy/DefaultMethods.java fails with jtreg 6
  • 995e956: 8266225: jarsigner is using incorrect security property to show weakness of certs
  • 0a12605: 8265448: (zipfs): Reduce read contention in ZipFileSystem
  • acf02ed: 8208237: Re-examine defmeth tests and update as needed
  • ac0287f: 8266770: Clean pending exception before running dynamic CDS dump
  • 7a0a57c: 8266820: micro java/nio/SelectorWakeup.java has wrong copyright header
  • d0daa72: 8266857: PipedOutputStream.sink should be volatile
  • 381de0c: 8266753: jdk/test/lib/process/ProcTest.java failed with "Exception: Proc abnormal end"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2021
@dougxc
Copy link
Member Author

dougxc commented May 12, 2021

/integrate

@openjdk openjdk bot closed this May 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

@dougxc Since your change was applied there have been 24 commits pushed to the master branch:

  • 548899d: 8266189: Remove C1 "IfInstanceOf" instruction
  • b46086d: 8266874: Clean up C1 canonicalizer for TableSwitch/LookupSwitch
  • 97367c0: 8266808: Search label still uses old search field id
  • 06d7602: 8261158: JVMState should not be shared between SafePointNodes
  • 476994a: 8266531: ZAddress::address() should be removed from SA
  • e828a93: 8261395: C1 crash "cannot make java calls from the native compiler"
  • 3c47cab: 8261034: improve jcmd GC.class_histogram to support parallel
  • ed32e02: 8241187: ToolBox::grep should allow for negative filtering
  • cc03734: 8266925: Add a test to verify that hidden class's members are not statically invocable
  • 271a0c7: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/2d2cd78bde7bb9101614a1ba2285d1e37d5d3249...master

Your commit was automatically rebased without conflicts.

Pushed as commit f3b510b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8266923 branch August 23, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants