Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266783: java/lang/reflect/Proxy/DefaultMethods.java fails with jtreg 6 #3984

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented May 11, 2021

Data provider with varargs does not work on TestNG 7.4.0. Fix the test to create an object array instead of varargs to workaround this issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266783: java/lang/reflect/Proxy/DefaultMethods.java fails with jtreg 6

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3984/head:pull/3984
$ git checkout pull/3984

Update a local copy of the PR:
$ git checkout pull/3984
$ git pull https://git.openjdk.java.net/jdk pull/3984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3984

View PR using the GUI difftool:
$ git pr show -t 3984

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3984.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@mlchung The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

@mbreinhold
Copy link
Member

All those backslashes hurt my eyes. Could we please use forward slashes, both in the commit message and the issue summary? This isn’t a regular expression.

@mlchung mlchung changed the title 8266783: java\lang\reflect\Proxy\DefaultMethods.java fails with jtreg 6 8266783: java/lang/reflect/Proxy/DefaultMethods.java fails with jtreg 6 May 11, 2021
@mlchung
Copy link
Member Author

mlchung commented May 11, 2021

Yes, fixing these is indeed looking more comfortable 😄

@openjdk
Copy link

openjdk bot commented May 11, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266783: java/lang/reflect/Proxy/DefaultMethods.java fails with jtreg 6

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • acf02ed: 8208237: Re-examine defmeth tests and update as needed
  • ac0287f: 8266770: Clean pending exception before running dynamic CDS dump

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2021
@mlchung
Copy link
Member Author

mlchung commented May 11, 2021

/integrate

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@mlchung Since your change was applied there have been 4 commits pushed to the master branch:

  • 995e956: 8266225: jarsigner is using incorrect security property to show weakness of certs
  • 0a12605: 8265448: (zipfs): Reduce read contention in ZipFileSystem
  • acf02ed: 8208237: Re-examine defmeth tests and update as needed
  • ac0287f: 8266770: Clean pending exception before running dynamic CDS dump

Your commit was automatically rebased without conflicts.

Pushed as commit dfe8833.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the JDK-8266783 branch November 4, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants