Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh #3989

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented May 11, 2021

Please see the bug report for detailed description of the issue. The simple fix for the test is to disable inlining of the lock() method (something which I think the existing MaxInlineLevel flags were trying to achieve but didn't).

Testing:

  • before fix I ran the test 50x on linux-x64, macos-x64 and macos-aarch64 product and fastdebug -> 300 failures
  • after: 300 successes
  • I also ran the fixed version 50x across all platforms using the test flags from tiers 1 through 8 (total of 1408 test runs) with zero failures or crashes.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3989/head:pull/3989
$ git checkout pull/3989

Update a local copy of the PR:
$ git checkout pull/3989
$ git pull https://git.openjdk.java.net/jdk pull/3989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3989

View PR using the GUI difftool:
$ git pr show -t 3989

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3989.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 11, 2021
@mlbridge
Copy link

mlbridge bot commented May 11, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on chasing this one to ground!

Thumbs up.

@openjdk
Copy link

openjdk bot commented May 11, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
  • 2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
  • accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
  • 69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
  • 7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
  • 4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
  • 11759bf: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion
  • dcf250d: 8233378: CHT: Fast reset
  • f3b510b: 8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI
  • 548899d: 8266189: Remove C1 "IfInstanceOf" instruction
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/18e9d28e8af02650ba30e4816404df48b1062162...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 11, 2021
@dholmes-ora
Copy link
Member Author

Thanks Dan. I'll push this now.

I also ran the fixed version of the test, 50x across all platforms using the test flags from tiers 1 through 8 (total of 1408 test runs) with zero failures or crashes. So confidence is high. :)

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@dholmes-ora Since your change was applied there have been 40 commits pushed to the master branch:

  • ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
  • 2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
  • accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
  • 69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
  • 7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
  • 4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
  • 11759bf: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion
  • dcf250d: 8233378: CHT: Fast reset
  • f3b510b: 8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI
  • 548899d: 8266189: Remove C1 "IfInstanceOf" instruction
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/18e9d28e8af02650ba30e4816404df48b1062162...master

Your commit was automatically rebased without conflicts.

Pushed as commit d215743.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8231031 branch May 13, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants