Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584 #399

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Sep 29, 2020

…s after JDK-8253584

The issue is (again) not normalized line endings for the test output - fixed in by normalizing the line endings in the actual output.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/399/head:pull/399
$ git checkout pull/399

@lahodaj
Copy link
Contributor Author

lahodaj commented Sep 29, 2020

/test

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2020

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2020
@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Sep 29, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

Could not create test job

@lahodaj lahodaj changed the title 8253770: Test tools/javac/parser/JavacParserTest.java fails on Window… 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584 Sep 29, 2020
@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
  • 3ed960e: 8253640: Make MEMFLAGS an enum class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2020
@lahodaj
Copy link
Contributor Author

lahodaj commented Sep 29, 2020

/integrate

@openjdk openjdk bot closed this Sep 29, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2020
@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@lahodaj Since your change was applied there have been 2 commits pushed to the master branch:

  • 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
  • 3ed960e: 8253640: Make MEMFLAGS an enum class

Your commit was automatically rebased without conflicts.

Pushed as commit d5be829.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants