New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264846: Regression ~5% in J2dBench.bimg_misc on Linux after JDK-8263142 #3990
Conversation
|
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@mrserb Since your change was applied there have been 16 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4086081. |
Performance in one of the tests in the bimg_misc group is dropped by 20%(or 5% of the group) after some unused code was removed from the libawt. I assume the size of the lib became smaller and GCC heuristics were changed to do not try to increase the size by inlining over some percent. I tested various options but most of them affect different test cases in the opposite ways.
While testing I have found that the most profitable option is to simply use the "O3" optimization level, moreover, after offline discussion, we have found that this optimization level was used before, but due to the typo, we missed this option and fallback to the "LOW" level.
Note this will change optimization level for all platforms in case of any regressions we may try to implement this change for GGC only or we may try to use just these options to solve this performance issue: " -ftree-loop-vectorize -fversion-loops-for-strides "
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3990/head:pull/3990
$ git checkout pull/3990
Update a local copy of the PR:
$ git checkout pull/3990
$ git pull https://git.openjdk.java.net/jdk pull/3990/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3990
View PR using the GUI difftool:
$ git pr show -t 3990
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3990.diff