JDK-8266651: Convert Table method parameters from String to Content

[hns]

This changes the parameter type for the tab label from String to Content in the formats.html.Table addTab and setDefaultTab methods. The change is straightforward because the tab name was converted to Content anyway, and all resources are readily available in Content form.

I briefly considered overriding the hashCode and equals methods in Text to be depend on content instead of object identity, but decided against it. This would just cover up bugs where we generate the same content twice. (In the process I made sure we currently don't have any such cases where a Text instance is compared to another one with the same string content.)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266651: Convert Table method parameters from String to Content

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3994/head:pull/3994
$ git checkout pull/3994

Update a local copy of the PR:
$ git checkout pull/3994
$ git pull https://git.openjdk.java.net/jdk pull/3994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3994

View PR using the GUI difftool:
$ git pr show -t 3994

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3994.diff

[bridgekeeper]

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hns The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0e1160f2)

[jonathan-gibbons]

NIce.

At some point, we should have a design discussion on the relative merits of Contents.getContent vs shared fields. FWIW, the current set of shared fields
is based on the evolution of history, and to some extent restricted by what was possible at the time.

[openjdk]

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266651: Convert Table method parameters from String to Content

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• fadf580: 8262952: [macos_aarch64] os::commit_memory failure
• f8f40ab: 8230486: G1BarrierSetAssembler::g1_write_barrier_post unnecessarily pushes/pops new_val
• 9d168e2: 8266973: Migrate to ClassHierarchyIterator when enumerating subclasses
• 02507bc: 8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java
• ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
• 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
• da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• ... and 60 more: https://git.openjdk.java.net/jdk/compare/4727187f86d18d34bd79cf93a74ff4a6515c662e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hns]

/integrate

[openjdk]

@hns Since your change was applied there have been 92 commits pushed to the master branch:

• e749f75: 8267304: Bump global JTReg memory limit to 768m
• e858dd6: 8267361: JavaTokenizer reads octal numbers mistakenly
• 1b93b81: 8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false
• 88b1142: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973
• 6ef46ce: 8231672: Simplify the reference processing parallelization framework
• 392f962: 8267151: C2: Don't create dummy Opaque1Node for outmost unswitched IfNode
• 0cf7e57: 8267239: C1: RangeCheckElimination for % operator if divisor is IntConstant
• 2d407e1: 8267293: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails when JTREG_JOBS > 25
• 70f6c67: 8233380: CHT: Node allocation and freeing
• 2563a6a: 8266962: Add arch supporting check for "Op_VectorLoadConst" before creating the node
• ... and 82 more: https://git.openjdk.java.net/jdk/compare/4727187f86d18d34bd79cf93a74ff4a6515c662e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 12050f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.