Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267043: IntelliJ project doesn't handle generated sources correctly #4000

Closed
wants to merge 2 commits into from

Conversation

@mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented May 12, 2021

Since generated sources are placed in the build folder, and since the build folder is indicated by the IntelliJ project settings as "project output", IntelliJ indexing blissfully ignores all the classes which are generated during the build.
This simple patch fixes that, by simply pointing the project output to a non-existing folder inside the build path (called idea).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267043: IntelliJ project doesn't handle generated sources correctly

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4000/head:pull/4000
$ git checkout pull/4000

Update a local copy of the PR:
$ git checkout pull/4000
$ git pull https://git.openjdk.java.net/jdk pull/4000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4000

View PR using the GUI difftool:
$ git pr show -t 4000

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4000.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 12, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@mcimadamore The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label May 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 12, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267043: IntelliJ project doesn't handle generated sources correctly

Reviewed-by: chegar, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
  • 69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
  • 7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
  • 4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
  • 11759bf: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion
  • dcf250d: 8233378: CHT: Fast reset
  • f3b510b: 8266923: [JVMCI] expose StackOverflow::_stack_overflow_limit to JVMCI
  • 548899d: 8266189: Remove C1 "IfInstanceOf" instruction
  • b46086d: 8266874: Clean up C1 canonicalizer for TableSwitch/LookupSwitch
  • 97367c0: 8266808: Search label still uses old search field id
  • ... and 37 more: https://git.openjdk.java.net/jdk/compare/de784312c340b4a4f4c4d11854bfbe9e9e826ea3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 12, 2021
@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented May 13, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@mcimadamore Since your change was applied there have been 52 commits pushed to the master branch:

  • 08a5a5c: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • b50fc5f: 8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.
  • d215743: 8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh
  • ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
  • 2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045
  • accbfea: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
  • 69daedf: 8266845: Shenandoah: Simplify SBS::load_reference_barrier implementation
  • 7433821: 8250658: Performance of ClipFlatOval Renderperf test is very low
  • 4727187: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
  • 11759bf: 8266798: C1: More types of instruction can also apply LoopInvariantCodeMotion
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/de784312c340b4a4f4c4d11854bfbe9e9e826ea3...master

Your commit was automatically rebased without conflicts.

Pushed as commit a270cbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants