-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045 #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
/label serviceability |
@plummercj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. This is a trivial fix.
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@plummercj Pushed as commit 2568d18. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8267045-8267045 removed this test from the ZGC problem list, but it still fails, so it needs to be re-added.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4002/head:pull/4002
$ git checkout pull/4002
Update a local copy of the PR:
$ git checkout pull/4002
$ git pull https://git.openjdk.java.net/jdk pull/4002/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4002
View PR using the GUI difftool:
$ git pr show -t 4002
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4002.diff