Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266162: Remove JPackage duplicate tests #4003

Closed

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented May 12, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4003/head:pull/4003
$ git checkout pull/4003

Update a local copy of the PR:
$ git checkout pull/4003
$ git pull https://git.openjdk.java.net/jdk pull/4003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4003

View PR using the GUI difftool:
$ git pr show -t 4003

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4003.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 12, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 12, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266162: Remove JPackage duplicate tests

Reviewed-by: almatvee, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • a564f2c: 8266821: G1: Prefetch cards during merge heap roots phase
  • 127bfe4: 8266074: Vtable-based CHA implementation
  • 347d41d: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • 17ceef9: 8266819: Separate the stop policies from the compile policies completely
  • a270cbe: 8267043: IntelliJ project doesn't handle generated sources correctly
  • 08a5a5c: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • b50fc5f: 8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.
  • d215743: 8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166 refresh
  • ab17be2: 8252530: Fix inconsistencies in hotspot whitebox
  • 2568d18: 8267047: Put serviceability/sa/TestJmapCoreMetaspace.java back on ZGC problem list due to JDK-8267045

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 13, 2021
@alexeysemenyukoracle
Copy link
Member Author

@alexeysemenyukoracle alexeysemenyukoracle commented May 13, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 13, 2021

@alexeysemenyukoracle Since your change was applied there have been 13 commits pushed to the master branch:

  • a259ab4: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
  • b4371e9: 8266552: Technical corrections to java/util/random/package-info.java
  • e14b026: 8243287: Removal of Unsafe::defineAnonymousClass
  • a564f2c: 8266821: G1: Prefetch cards during merge heap roots phase
  • 127bfe4: 8266074: Vtable-based CHA implementation
  • 347d41d: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption
  • 17ceef9: 8266819: Separate the stop policies from the compile policies completely
  • a270cbe: 8267043: IntelliJ project doesn't handle generated sources correctly
  • 08a5a5c: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • b50fc5f: 8265528: Specification of BasicSplitPaneDivider::getMinimumSize,getPreferredSize doesn't match with its behavior.
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/accbfeaf22ea5374292a657ddabb67b22eada6bc...master

Your commit was automatically rebased without conflicts.

Pushed as commit f3c6cda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants