-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267095: Miscellaneous cleanups in vm.runtime.defmeth tests #4008
Conversation
👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into |
@iwanowww |
Webrevs
|
JEP 306 (JDK-8175916) proposes removing ACC_STRICT for class file versions >= 61. See also #3891. So perhaps testing of ACC_STRICT should be removed from these tests? |
Thanks for taking a look, Harold.
Good point. I went ahead and removed all ACC_STRICT-related code. It could be kept for major version <= 60, but I don't see much sense in introducing additional test configuration. IMO testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Vladimir,
I took a scan through this huge change and things look okay to me.
One thing we seem to have lost is the documentation for what this setup code:
/* majorVer / Set.of(MAX_MAJOR_VER),
/ flags / Set.of(0, ACC_SYNCHRONIZED),
/ redefine / Set.of(false, true),
/ execMode */ Set.of(DIRECT, REFLECTION, INVOKE_EXACT, INVOKE_GENERIC, INVOKE_WITH_ARGS, INDY));
actually means.
Also references to JVMS8 should probably just say JVMS.
Thanks,
David
@iwanowww This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 81 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
for (int i = 0; i< majorVerValues.length; i++) { | ||
majorVerValues[i] = minMajorVer + i; | ||
majorVerValues[i] = MIN_MAJOR_VER + i; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that the stress tests will run for all class versions between JDK 1.5 and JDK 17 ? If so, maybe change it to just run for JDK 1.5, 11, and 17 releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that the stress test will randomly pick test cases with class file versions between MIN_MAJOR_VER
and MAX_MAJOR_VER
. IMO it's a decent compromise between testing only MIN_MAJOR_VER
and MAX_MAJOR_VER
(all other defmeth tests are configured that way) and always enumerating all the class file versions in every test (MIN_MAJOR_VER ... MAX_MAJOR_VER
). So, I'd prefer to keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This big cleanup looks good. I just had the one comment below about class file versions. Also, can you update the copyrights?
Thanks, Harold
Thanks for the review, David.
Do you think additional comments can improve the situation?
Fixed. |
Mailing list message from David Holmes on hotspot-runtime-dev: On 27/05/2021 10:36 pm, Vladimir Ivanov wrote:
I was thinking more of restoring something to the readme.
Thanks, |
1 similar comment
Mailing list message from David Holmes on hotspot-runtime-dev: On 27/05/2021 10:36 pm, Vladimir Ivanov wrote:
I was thinking more of restoring something to the readme.
Thanks, |
Mailing list message from Vladimir Ivanov on hotspot-runtime-dev:
Does it look better? https://github.com//pull/4008/commits/66cda654f93e30ad1a6b72c29fb83e84c1a7ae58 Best regards, |
1 similar comment
Mailing list message from Vladimir Ivanov on hotspot-runtime-dev:
Does it look better? https://github.com//pull/4008/commits/66cda654f93e30ad1a6b72c29fb83e84c1a7ae58 Best regards, |
Mailing list message from David Holmes on hotspot-runtime-dev: On 31/05/2021 9:19 pm, Vladimir Ivanov wrote:
Yes thanks. So these tests will now be updated on each release to update the max David
|
1 similar comment
Mailing list message from David Holmes on hotspot-runtime-dev: On 31/05/2021 9:19 pm, Vladimir Ivanov wrote:
Yes thanks. So these tests will now be updated on each release to update the max David
|
Mailing list message from Vladimir Ivanov on hotspot-runtime-dev:
Yes. (It is desirable, but not strictly required.) I also thought about other options (either (1) automatically detect Best regards, |
1 similar comment
Mailing list message from Vladimir Ivanov on hotspot-runtime-dev:
Yes. (It is desirable, but not strictly required.) I also thought about other options (either (1) automatically detect Best regards, |
Thanks for the reviews, Harold and David. /integrate |
@iwanowww Since your change was applied there have been 89 commits pushed to the
|
Miscellaneous refactorings/cleanups in
vm.runtime.defmeth
tests.In particular:
test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/scenarios
with enumeration of different test configurations in tests themselves;TestBuilder
as a parameter and initiate test execution from executor;V17
);Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4008/head:pull/4008
$ git checkout pull/4008
Update a local copy of the PR:
$ git checkout pull/4008
$ git pull https://git.openjdk.java.net/jdk pull/4008/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4008
View PR using the GUI difftool:
$ git pr show -t 4008
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4008.diff