8267112: JVMCI compiler modules should be kept upgradable

[vnkozlov]

JDK-8264806 changes removed sources and also removed JVMCI compiler from list of upgradable modules. JVMCI compiler modules should be upgradable in JDK to work with GraalVM.

Make these modules upgradable again and empty by leaving only reference to JVMCI (jdk.internal.vm.ci) module. It does not restore sources - only module-info.java files are kept.

Note, we continue discussion about JDK-8265091: "Use Module API to export JVMCI packages at runtime" to see if we can remove these module-info.java files.

Changes were proposed by @dougxc after testing JDK-8264806 changes with GraalVM.
I restored related code in some tests for them to pass.

Testing: full tier1-tier3.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267112: JVMCI compiler modules should be kept upgradable

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)
• dnsimon - Committer ⚠️ Added manually

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4014/head:pull/4014
$ git checkout pull/4014

Update a local copy of the PR:
$ git checkout pull/4014
$ git pull https://git.openjdk.java.net/jdk pull/4014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4014

View PR using the GUI difftool:
$ git pr show -t 4014

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4014.diff

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vnkozlov The following labels will be automatically applied to this pull request:

• build
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[dougxc]

Looks good. My only suggestion would have been to avoid mentioning "Graal" in the PR title and description. This is really about making jdk.internal.vm.compiler a placeholder module for any JVMCI based compiler, of which Graal is one example.

[mlbridge]

Webrevs

• 00: Full (f8422487)

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267112: JVMCI compiler modules should be kept upgradable

Reviewed-by: mchung, erikj, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
• 3b11d81: 8266742: Check W^X state on possible safepoint
• 79b3944: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS
• 3c010a7: 8265705: aarch64: KlassDecodeMovk mode broken
• cf97252: 8264561: javap get NegativeArraySizeException on bad instruction
• b8856b1: 8263614: javac allows local variables to be accessed from a static context
• ea36836: 8267236: Versioned platform link in TestMemberSummary.java
• d5a15f7: 8263438: Unused method AbstractMemberWriter.isInherited
• dd5a84c: 8267162: Add jtreg test group definitions for langtools
• 39a454b: 8260331: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "ERROR: icon and imageIcon not same."
• ... and 31 more: https://git.openjdk.java.net/jdk/compare/b4371e9bcaa1c8aa394b5eca409c5afc669cc146...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Thank you, Mandy.

[vnkozlov]

/reviewer credit @dougxc

[openjdk]

@vnkozlov
Reviewer dnsimon successfully credited.

[vnkozlov]

@erikj79, are you okay with these changes?

[vnkozlov]

Thank you, Erik.

[vnkozlov]

/integrate

[openjdk]

@vnkozlov Since your change was applied there have been 41 commits pushed to the master branch:

• da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
• 3b11d81: 8266742: Check W^X state on possible safepoint
• 79b3944: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS
• 3c010a7: 8265705: aarch64: KlassDecodeMovk mode broken
• cf97252: 8264561: javap get NegativeArraySizeException on bad instruction
• b8856b1: 8263614: javac allows local variables to be accessed from a static context
• ea36836: 8267236: Versioned platform link in TestMemberSummary.java
• d5a15f7: 8263438: Unused method AbstractMemberWriter.isInherited
• dd5a84c: 8267162: Add jtreg test group definitions for langtools
• 39a454b: 8260331: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "ERROR: icon and imageIcon not same."
• ... and 31 more: https://git.openjdk.java.net/jdk/compare/b4371e9bcaa1c8aa394b5eca409c5afc669cc146...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2effdd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.