-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8266851: Implement JEP 403: Strongly Encapsulate JDK Internals #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/csr |
/contributor add alanb |
👋 Welcome back mr! A progress list of the required criteria for merging this PR into |
@mbreinhold this pull request will not be integrated until the CSR request JDK-8266852 for issue JDK-8266851 has been approved. |
@mbreinhold |
@mbreinhold The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There are a few tests with
It would be good to remove these references to |
@mlchung Thanks for pointing out those stray uses of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@mbreinhold This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 80 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
I searched the test and src trees for other remaining usages "--illegal-access" and didn't find any more (except for localized resources).
It's likely that some of the updated tests no longer need "/othervm". It would need a close inspection of each test to see if it still needed.
test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java
Outdated
Show resolved
Hide resolved
test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hotspot changes look good.
Thanks, Harold
/integrate |
@mbreinhold Since your change was applied there have been 177 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e630235. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this implementation of JEP 403 (https://openjdk.java.net/jeps/403).
Alan Bateman is the original author of almost all of it. Passes tiers 1-3 on
{linux,macos,windows}-x64 and {linux,macos}-aarch64.
Progress
Issue
Reviewers
Contributors
<alanb@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4015/head:pull/4015
$ git checkout pull/4015
Update a local copy of the PR:
$ git checkout pull/4015
$ git pull https://git.openjdk.java.net/jdk pull/4015/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4015
View PR using the GUI difftool:
$ git pr show -t 4015
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4015.diff