8266851: Implement JEP 403: Strongly Encapsulate JDK Internals #4015

mbreinhold · 2021-05-13T17:14:36Z

Please review this implementation of JEP 403 (https://openjdk.java.net/jeps/403).
Alan Bateman is the original author of almost all of it. Passes tiers 1-3 on
{linux,macos,windows}-x64 and {linux,macos}-aarch64.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8266851: Implement JEP 403: Strongly Encapsulate JDK Internals

Reviewers

Mandy Chung (@mlchung - Reviewer)
Alan Bateman (@AlanBateman - Reviewer)
Harold Seigel (@hseigel - Reviewer)

Contributors

Alan Bateman <alanb@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4015/head:pull/4015
$ git checkout pull/4015

Update a local copy of the PR:
$ git checkout pull/4015
$ git pull https://git.openjdk.java.net/jdk pull/4015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4015

View PR using the GUI difftool:
$ git pr show -t 4015

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4015.diff

mbreinhold · 2021-05-13T17:15:02Z

/csr

mbreinhold · 2021-05-13T17:15:31Z

/contributor add alanb

bridgekeeper · 2021-05-13T17:15:33Z

👋 Welcome back mr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-05-13T17:17:06Z

@mbreinhold this pull request will not be integrated until the CSR request JDK-8266852 for issue JDK-8266851 has been approved.

openjdk · 2021-05-13T17:18:23Z

@mbreinhold
Contributor Alan Bateman <alanb@openjdk.org> successfully added.

openjdk · 2021-05-13T17:20:37Z

@mbreinhold The following labels will be automatically applied to this pull request:

core-libs
hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-05-13T17:24:10Z

Webrevs

src/hotspot/share/runtime/arguments.cpp

mlchung · 2021-05-13T18:16:23Z

There are a few tests with --illegal-access=deny for example

test/jdk/java/lang/ModuleTests/BasicModuleTest.java
test/jdk/java/lang/instrument/RedefineModuleTest.java
test/jdk/java/lang/invoke/CallerSensitiveAccess.java
test/jdk/java/lang/reflect/AccessibleObject/ - a few tests
test/jdk/jdk/modules/open/Basic.java
test/jdk/tools/launcher/modules/addexports/manifest/AddExportsAndOpensInManifest.java

It would be good to remove these references to --illegal-access option in this patch too.

mbreinhold · 2021-05-13T23:03:29Z

@mlchung Thanks for pointing out those stray uses of --illegal-access. I’ve removed them, along with the mention of --illegal-access in launcher.properties.

mlchung

Looks good.

openjdk · 2021-05-13T23:15:07Z

@mbreinhold This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266851: Implement JEP 403: Strongly Encapsulate JDK Internals

Co-authored-by: Alan Bateman <alanb@openjdk.org>
Reviewed-by: mchung, alanb, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

64e2479: 8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64
9760dba: 8267321: Use switch expression for VarHandle$AccessMode lookup
fdd0352: 8267338: [JVMCI] revive JVMCI API removed by JDK-8243287
0b49f5a: 8267257: Shenandoah: Always deduplicate strings when it is enabled during full gc
12050f0: 8266651: Convert Table method parameters from String to Content
e749f75: 8267304: Bump global JTReg memory limit to 768m
e858dd6: 8267361: JavaTokenizer reads octal numbers mistakenly
1b93b81: 8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false
88b1142: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973
6ef46ce: 8231672: Simplify the reference processing parallelization framework
... and 70 more: https://git.openjdk.java.net/jdk/compare/f3c6cda47631cc123dbcddbfb627dc05cf7bc13b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

AlanBateman

The changes look good.

I searched the test and src trees for other remaining usages "--illegal-access" and didn't find any more (except for localized resources).

It's likely that some of the updated tests no longer need "/othervm". It would need a close inspection of each test to see if it still needed.

test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java

hseigel

Hotspot changes look good.
Thanks, Harold

mbreinhold · 2021-05-26T20:54:10Z

/integrate

openjdk · 2021-05-26T20:56:18Z

@mbreinhold Since your change was applied there have been 177 commits pushed to the master branch:

8c4719a: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
c59484e: 8267653: Remove Mutex::_safepoint_check_sometimes
de91643: 8267611: Print more info when pointer_delta assert fails
a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
4343997: 8267708: Remove references to com.sun.tools.javadoc.**
f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
bf8d4a8: 8267583: jmod fails on symlink to class file
083416d: 8267130: Memory Overflow in Disassembler::load_library
... and 167 more: https://git.openjdk.java.net/jdk/compare/f3c6cda47631cc123dbcddbfb627dc05cf7bc13b...master

Your commit was automatically rebased without conflicts.

Pushed as commit e630235.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8266851: Implement JEP 403: Strongly Encapsulate JDK Internals

4e2cbf9

openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels May 13, 2021

openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 13, 2021

hseigel reviewed May 13, 2021

View reviewed changes

src/hotspot/share/runtime/arguments.cpp Show resolved Hide resolved

Remove stray mentions of the jdk.module.illegalAccess property

719ff4e

openjdk bot removed the csr Pull request needs approved CSR before integration label May 13, 2021

Remove now-unnecessary uses and mentions of the --illegal-access option

1c14998

mlchung approved these changes May 13, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 13, 2021

AlanBateman approved these changes May 14, 2021

View reviewed changes

test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java Outdated Show resolved Hide resolved

test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java Outdated Show resolved Hide resolved

Fix up IllegalAccessTest

cde0adb

AlanBateman approved these changes May 19, 2021

View reviewed changes

hseigel approved these changes May 19, 2021

View reviewed changes

mlchung approved these changes May 19, 2021

View reviewed changes

openjdk bot closed this May 26, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels May 26, 2021

openjdk bot removed the rfr Pull request is ready for review label May 26, 2021

TimvdLippe mentioned this pull request Jun 4, 2021

Mock enum with methods fails on Java 17 mockito/mockito#2315

Closed

8266851: Implement JEP 403: Strongly Encapsulate JDK Internals #4015

8266851: Implement JEP 403: Strongly Encapsulate JDK Internals #4015

Uh oh!

Conversation

mbreinhold commented May 13, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Contributors

Reviewing

Uh oh!

mbreinhold commented May 13, 2021

Uh oh!

mbreinhold commented May 13, 2021

Uh oh!

bridgekeeper bot commented May 13, 2021

Uh oh!

openjdk bot commented May 13, 2021

Uh oh!

openjdk bot commented May 13, 2021

Uh oh!

openjdk bot commented May 13, 2021

Uh oh!

mlbridge bot commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

mlchung commented May 13, 2021

Uh oh!

mbreinhold commented May 13, 2021

Uh oh!

mlchung left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlanBateman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hseigel left a comment

Choose a reason for hiding this comment

Uh oh!

mbreinhold commented May 26, 2021

Uh oh!

openjdk bot commented May 26, 2021

Uh oh!

Uh oh!

mbreinhold commented May 13, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented May 13, 2021 •

edited

Loading

openjdk bot commented May 13, 2021 •

edited

Loading