Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake #4017

Closed
wants to merge 1 commit into from

Conversation

iwanowww
Copy link
Contributor

@iwanowww iwanowww commented May 13, 2021

Fix a typo in the test.

Testing:

  • failing test on Ice Lake host

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4017/head:pull/4017
$ git checkout pull/4017

Update a local copy of the PR:
$ git checkout pull/4017
$ git pull https://git.openjdk.java.net/jdk pull/4017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4017

View PR using the GUI difftool:
$ git pr show -t 4017

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4017.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@iwanowww
The hotspot-compiler label was successfully added.

@iwanowww iwanowww marked this pull request as ready for review May 13, 2021 21:49
@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2021
@mlbridge
Copy link

mlbridge bot commented May 13, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk
Copy link

openjdk bot commented May 13, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 2667024: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • 6c107fd: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles
  • 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
  • f3c6cda: 8266162: Remove JPackage duplicate tests
  • a259ab4: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
  • b4371e9: 8266552: Technical corrections to java/util/random/package-info.java
  • e14b026: 8243287: Removal of Unsafe::defineAnonymousClass
  • a564f2c: 8266821: G1: Prefetch cards during merge heap roots phase

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2021
@iwanowww
Copy link
Contributor Author

Thanks for the review, Vladimir.

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@iwanowww Since your change was applied there have been 8 commits pushed to the master branch:

  • 2667024: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
  • 6c107fd: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles
  • 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
  • f3c6cda: 8266162: Remove JPackage duplicate tests
  • a259ab4: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
  • b4371e9: 8266552: Technical corrections to java/util/random/package-info.java
  • e14b026: 8243287: Removal of Unsafe::defineAnonymousClass
  • a564f2c: 8266821: G1: Prefetch cards during merge heap roots phase

Your commit was automatically rebased without conflicts.

Pushed as commit 2a2f105.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented May 14, 2021

@iwanowww Unknown command backport - for a list of valid commands use /help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants