-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249395: (macos) jpackage tests timeout on MacPro5_1 systems #4021
Conversation
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
@sashamatveev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
is JDK-8265294 also related to this ? |
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@sashamatveev Since your change was applied there have been 28 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 28f1c7a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Looks like it is similar to JDK-8236282, except for "hdiutil create". Based on call stack from failed test we launched "hdiutil create" and were waiting for it to terminate while reading output from it. However, based on process dump from machine which reproduced this issue, hdiutil no longer runs and existed long time ago. Fixed in same way as JDK-8236282 by writing output to file and then reading it back when process terminates.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4021/head:pull/4021
$ git checkout pull/4021
Update a local copy of the PR:
$ git checkout pull/4021
$ git pull https://git.openjdk.java.net/jdk pull/4021/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4021
View PR using the GUI difftool:
$ git pr show -t 4021
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4021.diff