8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

[sundararajana]

Problematic paths that start with /modules/modules prefix are handled properly

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

Reviewers

• Claes Redestad (@cl4es - Reviewer) ⚠️ Review applies to ba288d9
• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to ba288d9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4022/head:pull/4022
$ git checkout pull/4022

Update a local copy of the PR:
$ git checkout pull/4022
$ git pull https://git.openjdk.java.net/jdk pull/4022/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4022

View PR using the GUI difftool:
$ git pr show -t 4022

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4022.diff

[bridgekeeper]

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sundararajana The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (92611cbb)
• 00: Full (ba288d93)

[cl4es]

LGTM

[openjdk]

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

Reviewed-by: redestad, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 181 new commits pushed to the master branch:

• ebcf399: 8266622: Optimize Class.descriptorString() and Class.getCanonicalName0()
• 644f28c: 8266810: Move trivial Matcher code to cpu-specific header files
• 88907bb: 8266904: Use function pointer typedefs in OopOopIterateDispatch
• 301095c: 8266795: Remove dead code LowMemoryDetectorDisabler
• 1e0ecd6: 8265605: Cannot call BootLoader::loadClassOrNull before initPhase2
• 4086081: 8264846: Regression ~5% in J2dBench.bimg_misc on Linux after JDK-8263142
• 2a2f105: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
• 2667024: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• 6c107fd: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles
• 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
• ... and 171 more: https://git.openjdk.java.net/jdk/compare/c5dc657f0be90bd594663dcc612f40a930c2bbe7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

The code change looks fine. I guess I would probably change the comment to say that it make sure that there is something ending with "/" after "/modules/" (as the code that it comments doesn't actually change for a module name).

[sundararajana]

/integrate

[openjdk]

@sundararajana Since your change was applied there have been 181 commits pushed to the master branch:

• ebcf399: 8266622: Optimize Class.descriptorString() and Class.getCanonicalName0()
• 644f28c: 8266810: Move trivial Matcher code to cpu-specific header files
• 88907bb: 8266904: Use function pointer typedefs in OopOopIterateDispatch
• 301095c: 8266795: Remove dead code LowMemoryDetectorDisabler
• 1e0ecd6: 8265605: Cannot call BootLoader::loadClassOrNull before initPhase2
• 4086081: 8264846: Regression ~5% in J2dBench.bimg_misc on Linux after JDK-8263142
• 2a2f105: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
• 2667024: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• 6c107fd: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles
• 853ffdb: 8265934: Cleanup _suspend_flags and _special_runtime_exit_condition
• ... and 171 more: https://git.openjdk.java.net/jdk/compare/c5dc657f0be90bd594663dcc612f40a930c2bbe7...master

Your commit was automatically rebased without conflicts.

Pushed as commit af4cd04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.