8264408: test_oopStorage no longer needs to disable some tests on WIN32

[tstuefe]

The gtest gc/shared/test_oopStorage.cpp disables some tests on 32bit Windows because they use SafeFetch, which couldn't be used in the context where these tests were run. JDK-8185734 tracked the problem of using SafeFetch in gtests, and has since been fixed. So the OopStorage tests no longer need to be disabled.

Removing the test suppression involves removing the macro DISABLE_GARBAGE_ALLOCATION_STATUS_TEST and the #ifndef uses of it from test_oopStorage.cpp.

Note that the condition for defining that macro was botched, so that it applied to all Windows platforms, not just 32bit Windows. So the relevant tests haven't been executed on any version of Windows.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264408: test_oopStorage no longer needs to disable some tests on WIN32

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4026/head:pull/4026
$ git checkout pull/4026

Update a local copy of the PR:
$ git checkout pull/4026
$ git pull https://git.openjdk.java.net/jdk pull/4026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4026

View PR using the GUI difftool:
$ git pr show -t 4026

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4026.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e402fbeb)

[shipilev]

Looks good to me.

Oh wow, Microsoft docs on predefined macros: "_WIN32 Defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, or x64. Otherwise, undefined."

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264408: test_oopStorage no longer needs to disable some tests on WIN32

Reviewed-by: shade, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
• da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
• 3b11d81: 8266742: Check W^X state on possible safepoint
• 79b3944: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS
• ... and 31 more: https://git.openjdk.java.net/jdk/compare/408608130621b340151276dceeaf52cf6d037d53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Looks good to me.

Thanks!

Oh wow, Microsoft docs on predefined macros: "_WIN32 Defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, or x64. Otherwise, undefined."

Has been always this way. I believe it was used in the nineties to distinguish between 32bit and 16bit, now its just Windows.

..THomas

[tschatzl]

Lgtm.

[tstuefe]

Thanks @shipilev and @tschatzl .

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 41 commits pushed to the master branch:

• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
• da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
• 3b11d81: 8266742: Check W^X state on possible safepoint
• 79b3944: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS
• ... and 31 more: https://git.openjdk.java.net/jdk/compare/408608130621b340151276dceeaf52cf6d037d53...master

Your commit was automatically rebased without conflicts.

Pushed as commit da7c846.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.