Skip to content

JDK-8267187: Remove deprecated constructor for Log #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented May 14, 2021

In the course of other work, I came across this deprecated constructor in Log which just existed for a public entry point in javadoc which has already been removed.

There is one remaining use in javadoc, which can be changed to use an alternate non-deprecated constructor.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4037/head:pull/4037
$ git checkout pull/4037

Update a local copy of the PR:
$ git checkout pull/4037
$ git pull https://git.openjdk.java.net/jdk pull/4037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4037

View PR using the GUI difftool:
$ git pr show -t 4037

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4037.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2021

@jonathan-gibbons The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org compiler compiler-dev@openjdk.org labels May 14, 2021
@jonathan-gibbons jonathan-gibbons marked this pull request as ready for review May 14, 2021 20:59
@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2021
@mlbridge
Copy link

mlbridge bot commented May 14, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 14, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267187: Remove deprecated constructor for Log

Reviewed-by: iris, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fc08af5: 8174222: LambdaMetafactory: validate inputs and improve documentation
  • 5e557d8: 8266967: debug.cpp utility find() should print Java Object fields.
  • c7c77fd: 8255557: Decouple GCM from CipherCore

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 14, 2021
Vicente Romero and others added 20 commits May 20, 2021 17:53
Co-authored-by: Jatin Bhateja <jbhateja@openjdk.org>
Reviewed-by: neliasso, kvn
Reviewed-by: prappo, iris, vromero
…chFileException

Reviewed-by: asemenyuk, herrick
Reviewed-by: sgehwolf, egahlin
Reviewed-by: thartmann, redestad
Co-authored-by: Marcus G K Williams <mgkwill@openjdk.org>
Co-authored-by: Stefan Johansson <sjohanss@openjdk.org>
Co-authored-by: Thomas Stuefe <stuefe@openjdk.org>
Reviewed-by: stuefe, sjohanss
…nostic

8256301: ObjectMonitor::is_busy() should return bool

Reviewed-by: coleenp, pchilanomate
…a failed with OutOfMemoryError

Co-authored-by: xiangyuan <xiangyuan@tencent.com>
Reviewed-by: stuefe
Xin Liu and others added 23 commits June 7, 2021 06:12
…LibraryLookup is gone

Reviewed-by: zgu, jiefu
…ashed with OutOfMemory

Reviewed-by: tschatzl, kbarrett
…view)

Co-authored-by: Brian Goetz <briangoetz@openjdk.org>
Co-authored-by: Mandy Chung <mchung@openjdk.org>
Co-authored-by: Jan Lahoda <jlahoda@openjdk.org>
Reviewed-by: mcimadamore, forax, godin, psandoz, mchung
…art of the decorator set specified at creation.

Reviewed-by: dholmes, phh
…in JTreg compiler tests

Co-authored-by: Christian Hagedorn <chagedorn@openjdk.org>
Co-authored-by: Tobias Hartmann <thartmann@openjdk.org>
Reviewed-by: iignatyev
Reviewed-by: iris, erikj, jjg
@openjdk
Copy link

openjdk bot commented Jun 8, 2021

⚠️ @jonathan-gibbons This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Jun 8, 2021
@jonathan-gibbons
Copy link
Contributor Author

PR seems confused. New PR filed as #4404

@jonathan-gibbons jonathan-gibbons deleted the log-constructor branch June 8, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org javadoc javadoc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.