-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8266949: Check possibility to disable OperationTimedOut on Unix #4038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
Webrevs
|
@@ -1566,6 +1557,9 @@ private boolean isEQEmpty() { | |||
*/ | |||
@SuppressWarnings("serial") | |||
private final boolean waitForIdle(final long end) { | |||
if (timeout(end) <= 0) { | |||
return false; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the timeout is ended we will exit at the end of this method immediately, but let's post one less event to the EDT.
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@mrserb Since your change was applied there have been 49 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e6705c0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Our implementation of realSync on Unix is not straightforward, we try to move the awt root window and catch the ConfigureNotify. The problem is that the request to move the awt root window can be ignored, and it is possible that the notification will not come. In this case, we throw non-specified OperationTimedOut and it crashes the random tests here and there.
I have applied the same logic as on Windows and Linux we will wait till timeout(10 seconds) and then exit from the realsync.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4038/head:pull/4038
$ git checkout pull/4038
Update a local copy of the PR:
$ git checkout pull/4038
$ git pull https://git.openjdk.java.net/jdk pull/4038/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4038
View PR using the GUI difftool:
$ git pr show -t 4038
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4038.diff