Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264304: Create implementation for NSAccessibilityToolbar protocol peer #4040

Closed
wants to merge 2 commits into from

Conversation

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented May 15, 2021

Create implementation for accessibility native peer for Toolbar component.
There is no direct protocol for this role and there is no protocol in list of role based protocols defined by Apple Accessibility API, which can be used for this role directly. https://developer.apple.com/library/archive/documentation/Accessibility/Conceptual/AccessibilityMacOSX/ImplementingAccessibilityforCustomControls.html. So custom implementation of peer is created.

Accessibility support in JToolBar is very trivial, so the native peer is also simple.

I have tested this implementation by using the SwingSet2 demo and Toolbar samples present here https://docs.oracle.com/javase/tutorial/uiswing/components/toolbar.html. The Voice Over works fine and consistent with the old implementation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264304: Create implementation for NSAccessibilityToolbar protocol peer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4040/head:pull/4040
$ git checkout pull/4040

Update a local copy of the PR:
$ git checkout pull/4040
$ git pull https://git.openjdk.java.net/jdk pull/4040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4040

View PR using the GUI difftool:
$ git pr show -t 4040

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4040.diff

@pankaj-bansal pankaj-bansal marked this pull request as ready for review May 15, 2021
@pankaj-bansal pankaj-bansal marked this pull request as draft May 15, 2021
@pankaj-bansal pankaj-bansal marked this pull request as ready for review May 15, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 15, 2021

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2021

@pankaj-bansal The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label May 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 22, 2021

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264304: Create implementation for NSAccessibilityToolbar protocol peer

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 22, 2021
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented May 23, 2021

/integrate

@openjdk openjdk bot closed this May 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 23, 2021

@pankaj-bansal Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 4d26f22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pankaj-bansal pankaj-bansal deleted the JDK-8264304 branch May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants