8264304: Create implementation for NSAccessibilityToolbar protocol peer

[pankaj-bansal]

Create implementation for accessibility native peer for Toolbar component.
There is no direct protocol for this role and there is no protocol in list of role based protocols defined by Apple Accessibility API, which can be used for this role directly. https://developer.apple.com/library/archive/documentation/Accessibility/Conceptual/AccessibilityMacOSX/ImplementingAccessibilityforCustomControls.html. So custom implementation of peer is created.

Accessibility support in JToolBar is very trivial, so the native peer is also simple.

I have tested this implementation by using the SwingSet2 demo and Toolbar samples present here https://docs.oracle.com/javase/tutorial/uiswing/components/toolbar.html. The Voice Over works fine and consistent with the old implementation.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264304: Create implementation for NSAccessibilityToolbar protocol peer

Reviewers

• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4040/head:pull/4040
$ git checkout pull/4040

Update a local copy of the PR:
$ git checkout pull/4040
$ git pull https://git.openjdk.java.net/jdk pull/4040/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4040

View PR using the GUI difftool:
$ git pr show -t 4040

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4040.diff

[bridgekeeper]

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pankaj-bansal The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (efaa4574)
• 00: Full (df42f8db)

[openjdk]

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264304: Create implementation for NSAccessibilityToolbar protocol peer

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 71e2fa2: 8267531: [x86] Assembler::andb(Address,Register) encoding is incorrect
• 4023646: 8266528: Optimize C2 VerifyIterativeGVN execution time
• 2462316: 8261354: SIGSEGV at MethodIteratorHost
• 72c9567: 8263486: Clean up MTLSurfaceDataBase.h
• fe33343: 8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
• 8f10c5a: 8267190: Optimize Vector API test operations
• 94cfeb9: 8256155: Allow multiple large page sizes to be used on Linux
• ec8a809: 8267119: switch expressions lack support for deferred type-checking
• 4ba7613: 8267332: xor value should handle bounded values
• ee2651b: 8203359: Container level resources events
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/f07dcf471c160e09fbc748124998923e7d453e66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pankaj-bansal]

/integrate

[openjdk]

@pankaj-bansal Since your change was applied there have been 30 commits pushed to the master branch:

• 6288a99: 8267404: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
• 71e2fa2: 8267531: [x86] Assembler::andb(Address,Register) encoding is incorrect
• 4023646: 8266528: Optimize C2 VerifyIterativeGVN execution time
• 2462316: 8261354: SIGSEGV at MethodIteratorHost
• 72c9567: 8263486: Clean up MTLSurfaceDataBase.h
• fe33343: 8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
• 8f10c5a: 8267190: Optimize Vector API test operations
• 94cfeb9: 8256155: Allow multiple large page sizes to be used on Linux
• ec8a809: 8267119: switch expressions lack support for deferred type-checking
• 4ba7613: 8267332: xor value should handle bounded values
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/f07dcf471c160e09fbc748124998923e7d453e66...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4d26f22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.