Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264290: Create implementation for NSAccessibilityComponentGroup protocol peer #4046

Closed
wants to merge 1 commit into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented May 17, 2021

Initial implementation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264290: Create implementation for NSAccessibilityComponentGroup protocol peer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4046/head:pull/4046
$ git checkout pull/4046

Update a local copy of the PR:
$ git checkout pull/4046
$ git pull https://git.openjdk.java.net/jdk pull/4046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4046

View PR using the GUI difftool:
$ git pr show -t 4046

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4046.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label May 17, 2021
@mlbridge
Copy link

mlbridge bot commented May 17, 2021

Webrevs

@pankaj-bansal
Copy link

pankaj-bansal commented May 18, 2021

Could you please give some details about how you have tested this?

@azuev-java
Copy link
Member Author

azuev-java commented May 18, 2021

Could you please give some details about how you have tested this?

I used the SwingSet2 first demo - internal frame - and made sure that components that were previously reported as groups - internal frame, button group and such - are correctly reported as groups and there are no regressions with navigating their children using the accessibility shortcut keys. Also with debug output i made sure that new code is used to gather list of the children inside the group components. Additionally i tested it with few existing AWT tests and made sure that there are no regression there too.

*/

#import "GroupAccessibility.h"
#import "JNIUtilities.h"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header JNIUtilities.h is not used, please remove it before integrating.

Copy link

@pankaj-bansal pankaj-bansal left a comment

Looks fine to me.

@openjdk
Copy link

openjdk bot commented May 20, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264290: Create implementation for NSAccessibilityComponentGroup protocol peer

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • 8e3549f: 8266332: Adler32 intrinsic for x86 64-bit platforms
  • b961f25: 8267191: Avoid repeated SystemDictionaryShared::should_be_excluded calls
  • 74f30ad: 8263684: Avoid wrapping into BufferedWriter twice
  • 9820f3d: 8267371: Concurrent gtests take too long
  • 38d690b: 8265262: CITime - 'other' incorrectly calculated
  • 66ab6d8: 8264181: javadoc tool Incorrect error message about malformed link
  • 99fcc41: 8234532: Remove ThreadLocalAllocBuffer::_fast_refill_waste since it is never set
  • 237fee8: 8267339: Temporarily disable os.release_multi_mappings_vm on macOS x64
  • 64e2479: 8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64
  • 9760dba: 8267321: Use switch expression for VarHandle$AccessMode lookup
  • ... and 54 more: https://git.openjdk.java.net/jdk/compare/02f895c5f6f6de38549337d45ed8ba4c446e9677...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 20, 2021
@azuev-java
Copy link
Member Author

azuev-java commented May 20, 2021

/integrate

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 20, 2021
@openjdk
Copy link

openjdk bot commented May 20, 2021

@azuev-java Since your change was applied there have been 69 commits pushed to the master branch:

  • 31320c3: 8267262: com/sun/net/httpserver/Filter improve API documentation of static methods
  • 7dcb9fd: 8265684: implement Sealed Classes as a standard feature in Java, javadoc changes
  • 0fa9223: 8260517: implement Sealed Classes as a standard feature in Java
  • 31b98e1: 8265319: implement Sealed Classes as a standard feature in Java, javax.lang.model changes
  • 726785b: 8267155: runtime/os/TestTracePageSizes times out
  • 8e3549f: 8266332: Adler32 intrinsic for x86 64-bit platforms
  • b961f25: 8267191: Avoid repeated SystemDictionaryShared::should_be_excluded calls
  • 74f30ad: 8263684: Avoid wrapping into BufferedWriter twice
  • 9820f3d: 8267371: Concurrent gtests take too long
  • 38d690b: 8265262: CITime - 'other' incorrectly calculated
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/02f895c5f6f6de38549337d45ed8ba4c446e9677...master

Your commit was automatically rebased without conflicts.

Pushed as commit f07dcf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@azuev-java azuev-java deleted the JDK-8264290 branch Apr 7, 2022
@openjdk openjdk bot added the client label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client integrated
2 participants