Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267229: Split runtime/Metaspace/elastic test configurations for better scalability #4047

Closed
wants to merge 2 commits into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented May 17, 2021

JDK-8251158 added runtime/Metaspace/elastic tests that run in hotspot:tier1. Unfortunately, those tests are quite long, and they contribute to long tail in hotspot:tier1 on larger machines. We can split the test by configuration for better scalability.

Attention @tstuefe.

Additional testing:

  • affected tests on Linux x86_64, fastdebug/release
  • hotspot:tier1 on Linux x86_64, fastdebug

Times before:

# runtime/Metaspace/elastic

real	3m49.412s
user	9m27.347s
sys	0m30.982s

# hotspot:tier1

real	9m26.916s
user	273m45.575s
sys	24m49.788s

Times after:

# runtime/Metaspace/elastic

real	1m14.261s
user	9m51.823s
sys	0m31.092s

# hotspot:tier1

real	7m7.153s
user	268m49.231s
sys	25m53.377s

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267229: Split runtime/Metaspace/elastic test configurations for better scalability

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4047/head:pull/4047
$ git checkout pull/4047

Update a local copy of the PR:
$ git checkout pull/4047
$ git pull https://git.openjdk.java.net/jdk pull/4047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4047

View PR using the GUI difftool:
$ git pr show -t 4047

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4047.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the rfr label May 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

Loading

Copy link
Member

@tstuefe tstuefe left a comment

Very good, thanks for doing this.

BTW I plan to move part of them out of tier1 after JDK17, but atm would like to leave them in tier1 since Metaspace gets still worked on and JEP 387 is still fresh.

Cheers, Thomas

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267229: Split runtime/Metaspace/elastic test configurations for better scalability

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a555fd8: 8264734: Some SA classes could use better hashCode() implementation
  • 2313a21: 8266637: CHT: Add insert_and_get method
  • 7b736ec: 8266489: Enable G1 to use large pages on Windows when region size is larger than 2m

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 17, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 18, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@shipilev Since your change was applied there have been 20 commits pushed to the master branch:

  • b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
  • 905b41a: 8265711: C1: Intrinsify Class.getModifier method
  • 554caf3: 8251392: Consolidate Metaspace Statistics
  • 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
  • cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
  • 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
  • da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
  • 3b11d81: 8266742: Check W^X state on possible safepoint
  • 79b3944: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS
  • 3c010a7: 8265705: aarch64: KlassDecodeMovk mode broken
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

Your commit was automatically rebased without conflicts.

Pushed as commit f6c2891.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8267229-elastic-tests branch Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants