8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError

[FrauBoes]

The tests for afterHandler filters expect the filter operation to happen before the assertion. Very rarely this is not the case, the calling thread reads the response before the filter operation is executed, so the test value is not set before it is asserted.
This fix uses a CompletableFuture to ensure the test value has been updated before it is asserted.

While here, the change increases the thread-safety of the filter state of a context.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError

Reviewers

• Chris Hegarty (@ChrisHegarty - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)
• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4050/head:pull/4050
$ git checkout pull/4050

Update a local copy of the PR:
$ git checkout pull/4050
$ git pull https://git.openjdk.java.net/jdk pull/4050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4050

View PR using the GUI difftool:
$ git pr show -t 4050

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4050.diff

[bridgekeeper]

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@FrauBoes The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9fce47ce)

[openjdk]

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError

Reviewed-by: chegar, dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
• da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
• 3b11d81: 8266742: Check W^X state on possible safepoint
• 79b3944: 8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/7b736ec9323a508cce164266b8e9a702527f3361...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

LGTM!

[Michael-Mc-Mahon]

LGTM

[FrauBoes]

/integrate

[openjdk]

@FrauBoes Since your change was applied there have been 21 commits pushed to the master branch:

• da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
• da4dfde: 8264777: Overload optimized FileInputStream::readAllBytes
• 3b11d81: 8266742: Check W^X state on possible safepoint
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/7b736ec9323a508cce164266b8e9a702527f3361...master

Your commit was automatically rebased without conflicts.

Pushed as commit 894547d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.