Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8267236: Versioned platform link in TestMemberSummary.java #4051

Closed
wants to merge 1 commit into from

Conversation

@hns
Copy link
Member

@hns hns commented May 17, 2021

Simple change to disable platform links in TestMemberSummary.java tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267236: Versioned platform link in TestMemberSummary.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4051/head:pull/4051
$ git checkout pull/4051

Update a local copy of the PR:
$ git checkout pull/4051
$ git pull https://git.openjdk.java.net/jdk pull/4051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4051

View PR using the GUI difftool:
$ git pr show -t 4051

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4051.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the javadoc label May 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

Loading

Copy link
Member

@pavelrappo pavelrappo left a comment

The change looks good. That said, should we be concerned about proliferation of --no-platform-links in tests?

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267236: Versioned platform link in TestMemberSummary.java

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 17, 2021
@hns
Copy link
Member Author

@hns hns commented May 17, 2021

The change looks good. That said, should we be concerned about proliferation of --no-platform-links in tests?

If I remember correctly, back when we did the platform link feature @jonathan-gibbons suggested disabling the feature by default in JavadocTester. That would help avoid this kind of mistake. However, I don't think we have a mechanism to tweak standard options in JavadocTester, and I'm not sure how we would then enable the feature in order to test it.

Loading

@hns
Copy link
Member Author

@hns hns commented May 17, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@hns Since your change was applied there have been 4 commits pushed to the master branch:

  • d5a15f7: 8263438: Unused method AbstractMemberWriter.isInherited
  • dd5a84c: 8267162: Add jtreg test group definitions for langtools
  • 39a454b: 8260331: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "ERROR: icon and imageIcon not same."
  • a29612e: 8255661: TestHeapDumpOnOutOfMemoryError fails with EOFException

Your commit was automatically rebased without conflicts.

Pushed as commit ea36836.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants