Skip to content

8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aghaisas
Copy link
Contributor

@aghaisas aghaisas commented May 17, 2021

This PR reverts to OpenGL as the default Java2D rendering pipeline for macOS.

Note : from JBS description :
In JDK 17 build 19 under bug id JDK-8265304 we switched to Metal as the default rendering pipeline with the plan that it would be reverted to OpenGL after 4 builds.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4052/head:pull/4052
$ git checkout pull/4052

Update a local copy of the PR:
$ git checkout pull/4052
$ git pull https://git.openjdk.java.net/jdk pull/4052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4052

View PR using the GUI difftool:
$ git pr show -t 4052

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4052.diff

@aghaisas
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

@aghaisas the issue for this pull request, JDK-8266520, already has an approved CSR request: JDK-8266521

@openjdk
Copy link

openjdk bot commented May 17, 2021

@aghaisas The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label May 17, 2021
@mlbridge
Copy link

mlbridge bot commented May 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 17, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266520: Revert to OpenGL as the default 2D rendering pipeline for macOS

Reviewed-by: azvegint, trebari, kcr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • b8856b1: 8263614: javac allows local variables to be accessed from a static context
  • ea36836: 8267236: Versioned platform link in TestMemberSummary.java
  • d5a15f7: 8263438: Unused method AbstractMemberWriter.isInherited
  • dd5a84c: 8267162: Add jtreg test group definitions for langtools
  • 39a454b: 8260331: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "ERROR: icon and imageIcon not same."
  • a29612e: 8255661: TestHeapDumpOnOutOfMemoryError fails with EOFException
  • a555fd8: 8264734: Some SA classes could use better hashCode() implementation
  • 2313a21: 8266637: CHT: Add insert_and_get method

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 17, 2021
@aghaisas
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this May 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

@aghaisas Since your change was applied there have been 10 commits pushed to the master branch:

  • 3c010a7: 8265705: aarch64: KlassDecodeMovk mode broken
  • cf97252: 8264561: javap get NegativeArraySizeException on bad instruction
  • b8856b1: 8263614: javac allows local variables to be accessed from a static context
  • ea36836: 8267236: Versioned platform link in TestMemberSummary.java
  • d5a15f7: 8263438: Unused method AbstractMemberWriter.isInherited
  • dd5a84c: 8267162: Add jtreg test group definitions for langtools
  • 39a454b: 8260331: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "ERROR: icon and imageIcon not same."
  • a29612e: 8255661: TestHeapDumpOnOutOfMemoryError fails with EOFException
  • a555fd8: 8264734: Some SA classes could use better hashCode() implementation
  • 2313a21: 8266637: CHT: Add insert_and_get method

Your commit was automatically rebased without conflicts.

Pushed as commit 79b3944.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants