Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false #4056

Closed
wants to merge 2 commits into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented May 17, 2021

RestorePreservedMarks, and RemoveSelfForwardingPtr are conditionally emitted (only on evac failure). Updating the test to exclude these events in the assert.

double G1GCPhaseTimes::print_post_evacuate_collection_set() const {
  ...
  debug_phase(_gc_par_phases[RecalculateUsed], 1);
  if (G1CollectedHeap::heap()->evacuation_failed()) {
    debug_phase(_gc_par_phases[RemoveSelfForwardingPtr], 1);
  }

  debug_time("Post Evacuate Cleanup 2", _cur_post_evacuate_cleanup_2_time_ms);
  if (G1CollectedHeap::heap()->evacuation_failed()) {
    debug_phase(_gc_par_phases[RecalculateUsed], 1);
    debug_phase(_gc_par_phases[RestorePreservedMarks], 1);
  }
  ...
}

Tested: manually set a smaller heap size to see the test fail, but pass with the PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false
  • JDK-8267218: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not found phases: StringDedupQueueFixup, StringDedupTableFixup

Reviewers

Contributors

  • Thomas Schatzl <tschatzl@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4056/head:pull/4056
$ git checkout pull/4056

Update a local copy of the PR:
$ git checkout pull/4056
$ git pull https://git.openjdk.java.net/jdk pull/4056/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4056

View PR using the GUI difftool:
$ git pr show -t 4056

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4056.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label May 17, 2021
@openjdk openjdk bot added the rfr label May 17, 2021
@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented May 17, 2021

/issue add JDK-8267218
/contributor add tschatzl

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@albertnetymk
Adding additional issue to issue list: 8267218: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not found phases\: StringDedupQueueFixup, StringDedupTableFixup.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@albertnetymk
Contributor Thomas Schatzl <tschatzl@openjdk.org> successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

Fwiw (for other reviewers), the evacuation failure phase events only now give problems because JDK-8214237 added them (in case of evac failure) but they were never posted before. Evac failure in this test is unreliable, so they are put into the optPhases list.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false
8267218: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not found phases\: StringDedupQueueFixup, StringDedupTableFixup

Co-authored-by: Thomas Schatzl <tschatzl@openjdk.org>
Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 70f6c67: 8233380: CHT: Node allocation and freeing
  • 2563a6a: 8266962: Add arch supporting check for "Op_VectorLoadConst" before creating the node
  • 4954383: 8267364: Remove mask.incr which is introduced by JDK-8256973
  • c2b50f9: 8266480: Implicit null check optimization does not update control of hoisted memory operation
  • 3f883e8: 8267351: runtime/cds/SharedBaseAddress.java fails on x86_32 due to Unrecognized VM option 'UseCompressedOops'
  • 7aa6568: 8256973: Intrinsic creation for VectorMask query (lastTrue,firstTrue,trueCount) APIs
  • 65a8bf5: 8265126: [REDO] unified handling for VectorMask object re-materialization during de-optimization
  • ff84577: 8267098: AArch64: C1 StubFrames end confusingly
  • 0daec49: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines
  • 324defe: 8267212: test/jdk/java/util/Collections/FindSubList.java intermittent crash with "no reachable node should have no use"
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/a555fd89d040792d4de73ab67d86b171a38cfde6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 17, 2021
@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented May 19, 2021

Thanks for the review.

/integrate

Loading

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@albertnetymk Since your change was applied there have been 44 commits pushed to the master branch:

  • 88b1142: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973
  • 6ef46ce: 8231672: Simplify the reference processing parallelization framework
  • 392f962: 8267151: C2: Don't create dummy Opaque1Node for outmost unswitched IfNode
  • 0cf7e57: 8267239: C1: RangeCheckElimination for % operator if divisor is IntConstant
  • 2d407e1: 8267293: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails when JTREG_JOBS > 25
  • 70f6c67: 8233380: CHT: Node allocation and freeing
  • 2563a6a: 8266962: Add arch supporting check for "Op_VectorLoadConst" before creating the node
  • 4954383: 8267364: Remove mask.incr which is introduced by JDK-8256973
  • c2b50f9: 8266480: Implicit null check optimization does not update control of hoisted memory operation
  • 3f883e8: 8267351: runtime/cds/SharedBaseAddress.java fails on x86_32 due to Unrecognized VM option 'UseCompressedOops'
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/a555fd89d040792d4de73ab67d86b171a38cfde6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1b93b81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@albertnetymk albertnetymk deleted the evac-failure branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants