Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266957: SA has not followed JDK-8220587 and JDK-8224965 #4057

Closed
wants to merge 3 commits into from

Conversation

@YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented May 17, 2021

Following jtreg tests for SA would fail because SA has not followed JDK-8220587 and JDK-8224965.

  • serviceability/sa/ClhsdbDumpheap.java
  • serviceability/sa/ClhsdbFindPC.java
  • serviceability/sa/ClhsdbInspect.java
  • serviceability/sa/ClhsdbSymbol.java
  • serviceability/sa/TestHeapDumpForInvokeDynamic.java
  • serviceability/sa/TestJmapCore.java
  • serviceability/sa/TestJmapCoreMetaspace.java

They need to handle relocated objects and/or live regions (pages). SA should handle them.

This change passes serviceability/sa jtreg tests on Linux x64 with -vmoption:-XX:+UseZGC, but I want to know this change works fine on testbed for ZGC in Oracle. Could you help?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266957: SA has not followed JDK-8220587 and JDK-8224965

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4057/head:pull/4057
$ git checkout pull/4057

Update a local copy of the PR:
$ git checkout pull/4057
$ git pull https://git.openjdk.java.net/jdk pull/4057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4057

View PR using the GUI difftool:
$ git pr show -t 4057

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4057.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@YaSuenag YaSuenag changed the title Jdk 8266957 8266957: SA has not followed JDK-8220587 and JDK-8224965 May 17, 2021
@openjdk openjdk bot added the rfr label May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@YaSuenag The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

@YaSuenag
Copy link
Member Author

@YaSuenag YaSuenag commented May 27, 2021

Ping: could you review this change?
I know this is too big to review, so it is also welcome to comment to divide this PR.

This PR would fix JDK-8267045 which is marked as P3. If we can mark P3 to this PR, we can get more time to review.
I think SA should support ZGC as possible in next major release.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 1, 2021

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266957: SA has not followed JDK-8220587 and JDK-8224965

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 278 new commits pushed to the master branch:

  • 516e60a: 8268095: CDS MethodHandle tests should add -XX:-VerifyDependencies
  • c1f3094: 8267939: Clarify the specification of iterator and spliterator forEachRemaining
  • 460ce55: 8266019: StreamResult(File) writes to incorrect file path if # is part of the file path
  • b955865: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass
  • 9f05c41: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics
  • e27c4d4: 8268185: Update GitHub Actions for jtreg 6
  • 68ac871: 8268189: ProblemList compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java in -Xcomp mode
  • af3df63: 8267598: jpackage removes system libraries from java.library.path
  • 52d8215: 8268131: 2 java/foreign tests timed out
  • 5405f98: 8268077: java.util.List missing from Collections Framework Overview
  • ... and 268 more: https://git.openjdk.java.net/jdk/compare/02f895c5f6f6de38549337d45ed8ba4c446e9677...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 1, 2021
@YaSuenag
Copy link
Member Author

@YaSuenag YaSuenag commented Jun 1, 2021

Thanks @plummercj for the review!
May I get the review from ZGC folks?

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 2, 2021

May I get the review from ZGC folks?

The ZGC team won't be doing SA code reviews. I'll have someone else from the svc team do a second review, but keep in mind these reviews are primarily just to make sure the changes won't break anything (other than SA support for ZGC).

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Yasumasa,
This looks okay to me.
Thanks,
Serguei

@YaSuenag
Copy link
Member Author

@YaSuenag YaSuenag commented Jun 5, 2021

/integrate

@openjdk openjdk bot closed this Jun 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@YaSuenag Since your change was applied there have been 294 commits pushed to the master branch:

  • 6ff978a: 8267204: Expose access to underlying streams in Reporter
  • 76b54a1: 8263512: [macos_aarch64] issues with calling va_args functions from invoke_native
  • 4e6748c: 8267687: ModXNode::Ideal optimization is better than Parse::do_irem
  • 48dc72b: 8268272: Remove JDK-8264874 changes because Graal was removed.
  • 20b6312: 8268151: Vector API toShuffle optimization
  • 64ec8b3: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash
  • cd0678f: 8199318: add idempotent copy operation for Map.Entry
  • b27599b: 8268222: javax/xml/jaxp/unittest/transform/Bug6216226Test.java failed, cannot delete file
  • 59a539f: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries
  • 40c9e25: 8265444: Javadocs: jdk.jshell - small typo
  • ... and 284 more: https://git.openjdk.java.net/jdk/compare/02f895c5f6f6de38549337d45ed8ba4c446e9677...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7e41ca3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@YaSuenag YaSuenag deleted the JDK-8266957 branch Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants