New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266957: SA has not followed JDK-8220587 and JDK-8224965 #4057
Conversation
|
Ping: could you review this change? This PR would fix JDK-8267045 which is marked as P3. If we can mark P3 to this PR, we can get more time to review. |
@YaSuenag This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 278 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks @plummercj for the review! |
The ZGC team won't be doing SA code reviews. I'll have someone else from the svc team do a second review, but keep in mind these reviews are primarily just to make sure the changes won't break anything (other than SA support for ZGC). |
/integrate |
@YaSuenag Since your change was applied there have been 294 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7e41ca3. |
Following jtreg tests for SA would fail because SA has not followed JDK-8220587 and JDK-8224965.
They need to handle relocated objects and/or live regions (pages). SA should handle them.
This change passes serviceability/sa jtreg tests on Linux x64 with -vmoption:-XX:+UseZGC, but I want to know this change works fine on testbed for ZGC in Oracle. Could you help?
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4057/head:pull/4057
$ git checkout pull/4057
Update a local copy of the PR:
$ git checkout pull/4057
$ git pull https://git.openjdk.java.net/jdk pull/4057/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4057
View PR using the GUI difftool:
$ git pr show -t 4057
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4057.diff