8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java

[hseigel]

Please review this small change to remove unused LoadClass.java and remove comments that reference it. Mach5 tiers 1-3 were run to sanity check that LoadClass.java is not used.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java

Reviewers

• Gerard Ziemski (@gerard-ziemski - Committer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4059/head:pull/4059
$ git checkout pull/4059

Update a local copy of the PR:
$ git checkout pull/4059
$ git pull https://git.openjdk.java.net/jdk pull/4059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4059

View PR using the GUI difftool:
$ git pr show -t 4059

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4059.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[hseigel]

/label remove hotspot
/label add hotspot-runtime
/label add hotspot-test

[openjdk]

@hseigel
The hotspot label was successfully removed.

[openjdk]

@hseigel
The hotspot-runtime label was successfully added.

[openjdk]

@hseigel The label hotspot-test is not a valid label. These labels are valid:

• serviceability
• hotspot
• sound
• hotspot-compiler
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• 2d
• security
• swing
• hotspot-runtime
• jmx
• build
• nio
• beans
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr
• awt

[mlbridge]

Webrevs

• 00: Full (cac3a243)

[gerard-ziemski]

I grepped test/hotspot for LoadClass and I think that you got them all, thanks!

[coleenp]

Looks good plus trivial to check in.

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java

Reviewed-by: gziemski, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
• 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
• da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/a29612ea9998a8e45f25add7ae30bfbc62ce3756...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hseigel]

Thanks Gerard and Coleen for reviewing this!

/integrate

[openjdk]

@hseigel Since your change was applied there have been 20 commits pushed to the master branch:

• ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
• 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
• da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• cd1c17c: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• 2effdd1: 8267112: JVMCI compiler modules should be kept upgradable
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/a29612ea9998a8e45f25add7ae30bfbc62ce3756...master

Your commit was automatically rebased without conflicts.

Pushed as commit 02507bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.