8230486: G1BarrierSetAssembler::g1_write_barrier_post unnecessarily pushes/pops new_val

[albertnetymk]

Removes the unnecessary push/pop instruction.

Test: hotspot_gc

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8230486: G1BarrierSetAssembler::g1_write_barrier_post unnecessarily pushes/pops new_val

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4063/head:pull/4063
$ git checkout pull/4063

Update a local copy of the PR:
$ git checkout pull/4063
$ git pull https://git.openjdk.java.net/jdk pull/4063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4063

View PR using the GUI difftool:
$ git pr show -t 4063

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4063.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (821a2650)
• 00: Full (df025947)

[kimbarrett]

aarch64 looks like it has the same problem. I think other platforms don't.

[tschatzl]

Looks good.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8230486: G1BarrierSetAssembler::g1_write_barrier_post unnecessarily pushes/pops new_val

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 9d168e2: 8266973: Migrate to ClassHierarchyIterator when enumerating subclasses
• 02507bc: 8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java
• ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
• 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
• da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/a555fd89d040792d4de73ab67d86b171a38cfde6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

@albertnetymk Since your change was applied there have been 23 commits pushed to the master branch:

• 9d168e2: 8266973: Migrate to ClassHierarchyIterator when enumerating subclasses
• 02507bc: 8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java
• ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
• 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
• da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
• f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
• b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
• 905b41a: 8265711: C1: Intrinsify Class.getModifier method
• 554caf3: 8251392: Consolidate Metaspace Statistics
• 3e97b07: 8267116: Lanai: Incorrect AlphaComposite for VolatileImage graphics
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/a555fd89d040792d4de73ab67d86b171a38cfde6...master

Your commit was automatically rebased without conflicts.

Pushed as commit f8f40ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.