Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265262: CITime - 'other' incorrectly calculated #4065

Closed
wants to merge 4 commits into from

Conversation

@neliasso
Copy link
Contributor

@neliasso neliasso commented May 17, 2021

This CR fixes a few issues with the CITIme output for C2:

  1. The other category for _t_optimize is not removing time spent in _t_vector

  2. Some of the _t_incrInline sub counters is called from different contexts - calculating 'other' from total time spent in _t_incrInline expects that the counter usage is strictly hierarchical.

  3. I've placed the non-hierarchical counters in braces.

  4. Code Installation is a part of Code Emission (_t_output). Indentation fixed.

  5. Moved "renumber live" after "Vector" so that they appear in order.

  6. Added sub counters "shorten branches" and "fill buffer" to "Code Emission" phase, and added an other category. Before more than 50% of time in Code Emission was unaccounted for, now it's less than 25%.

Please review,
Best regards,
Nils Eliasson


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4065/head:pull/4065
$ git checkout pull/4065

Update a local copy of the PR:
$ git checkout pull/4065
$ git pull https://git.openjdk.java.net/jdk pull/4065/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4065

View PR using the GUI difftool:
$ git pr show -t 4065

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4065.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@neliasso The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@neliasso neliasso marked this pull request as ready for review May 17, 2021
@openjdk openjdk bot added the rfr label May 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265262: CITime - 'other' incorrectly calculated

Reviewed-by: thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0cf7e57: 8267239: C1: RangeCheckElimination for % operator if divisor is IntConstant
  • 2d407e1: 8267293: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails when JTREG_JOBS > 25

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 18, 2021
@neliasso
Copy link
Contributor Author

@neliasso neliasso commented May 19, 2021

Thanks for the reviews, Tobias and Vladimir.

Loading

@neliasso
Copy link
Contributor Author

@neliasso neliasso commented May 19, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@neliasso Since your change was applied there have been 16 commits pushed to the master branch:

  • 66ab6d8: 8264181: javadoc tool Incorrect error message about malformed link
  • 99fcc41: 8234532: Remove ThreadLocalAllocBuffer::_fast_refill_waste since it is never set
  • 237fee8: 8267339: Temporarily disable os.release_multi_mappings_vm on macOS x64
  • 64e2479: 8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64
  • 9760dba: 8267321: Use switch expression for VarHandle$AccessMode lookup
  • fdd0352: 8267338: [JVMCI] revive JVMCI API removed by JDK-8243287
  • 0b49f5a: 8267257: Shenandoah: Always deduplicate strings when it is enabled during full gc
  • 12050f0: 8266651: Convert Table method parameters from String to Content
  • e749f75: 8267304: Bump global JTReg memory limit to 768m
  • e858dd6: 8267361: JavaTokenizer reads octal numbers mistakenly
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/70f6c67051135ff1d9994089b88d8ea630932046...master

Your commit was automatically rebased without conflicts.

Pushed as commit 38d690b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants