Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor #407

Closed
wants to merge 2 commits into from

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Sep 29, 2020

This change prevents a call to CompilerToVM.resolveMethod with an argument representing a constructor. Such a call triggers an assertion in a fastdebug VM.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/407/head:pull/407
$ git checkout pull/407

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2020

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2020

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 4b16f8a: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • 4fb8c77: 8253733: Cleanup internal taglet API
  • e5ba020: 8253829: Wrong length compared in SSPI bridge
  • 9e453d9: 8239090: Improve CPU feature support in VM_Version
  • 8f7c9a7: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi
  • 8cf8e46: 8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration
  • 8b3d676: 8238737: remove DeoptimizeAllClassesRate from CTW library
  • 709cfe5: 8253815: Remove unused HeapRegionManager::_num_committed from SA
  • f80a606: 8253375: OSX build fails with Xcode 12.0 (12A7209)
  • 04775f1: 8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad).
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/b1ce6bdba9ce9a9dcdeb63bca1b2a502bc61bd63...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 30, 2020
@dougxc
Copy link
Member Author

@dougxc dougxc commented Sep 30, 2020

/integrate

@openjdk openjdk bot closed this Sep 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2020

@dougxc Since your change was applied there have been 25 commits pushed to the master branch:

  • 2a406f3: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
  • 4b16f8a: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • 4fb8c77: 8253733: Cleanup internal taglet API
  • e5ba020: 8253829: Wrong length compared in SSPI bridge
  • 9e453d9: 8239090: Improve CPU feature support in VM_Version
  • 8f7c9a7: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi
  • 8cf8e46: 8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration
  • 8b3d676: 8238737: remove DeoptimizeAllClassesRate from CTW library
  • 709cfe5: 8253815: Remove unused HeapRegionManager::_num_committed from SA
  • f80a606: 8253375: OSX build fails with Xcode 12.0 (12A7209)
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/b1ce6bdba9ce9a9dcdeb63bca1b2a502bc61bd63...master

Your commit was automatically rebased without conflicts.

Pushed as commit 424d7d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Sep 30, 2020

@dougxc Can you explain why changes in TestResolvedJavaType.java test were not ported?

@dougxc
Copy link
Member Author

@dougxc dougxc commented Sep 30, 2020

Oversight. I'll fix this now.

@dougxc dougxc deleted the JDK-8252881 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants