Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267304: Bump global JTReg memory limit to 768m #4087

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented May 18, 2021

See the rationale in the RFE.

Additional testing:

  • Linux x86_64 fastdebug java/time/format/TestZoneTextPrinterParser.java with aggressive GC options
  • Linux x86_64 fastdebug jdk:tier1
  • Linux x86_64 fastdebug tier1
  • Linux x86_64 fastdebug tier2
  • Linux x86_32 fastdebug tier1
  • Linux x86_32 fastdebug tier2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4087/head:pull/4087
$ git checkout pull/4087

Update a local copy of the PR:
$ git checkout pull/4087
$ git pull https://git.openjdk.java.net/jdk pull/4087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4087

View PR using the GUI difftool:
$ git pr show -t 4087

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4087.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 18, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label May 18, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 18, 2021

/label remove build
/label add jdk

@openjdk openjdk bot removed the build label May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@shipilev
The build label was successfully removed.

@openjdk openjdk bot added the jdk label May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@shipilev
The jdk label was successfully added.

@shipilev shipilev marked this pull request as ready for review May 18, 2021
@openjdk openjdk bot added the rfr label May 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 18, 2021

Webrevs

Copy link
Member

@lmesnik lmesnik left a comment

Shouldn't affect VM testing. Fine with core-svc setting.

Copy link
Member

@iignatev iignatev left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267304: Bump global JTReg memory limit to 768m

Reviewed-by: lmesnik, iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • b92c5a4: 8265292: [macos_aarch64] java/foreign/TestDowncall.java crashes with SIGBUS
  • fadf580: 8262952: [macos_aarch64] os::commit_memory failure
  • f8f40ab: 8230486: G1BarrierSetAssembler::g1_write_barrier_post unnecessarily pushes/pops new_val
  • 9d168e2: 8266973: Migrate to ClassHierarchyIterator when enumerating subclasses
  • 02507bc: 8267166: Remove test file vmTestbase/vm/mlvm/tools/LoadClass.java
  • ce88b33: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • 894547d: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError
  • da7c846: 8264408: test_oopStorage no longer needs to disable some tests on WIN32
  • f6c2891: 8267229: Split runtime/Metaspace/elastic test configurations for better scalability
  • b60975d: 8267237: ARM32: bad AD file in matcher.cpp after 8266810
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 18, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 19, 2021

/integrate

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@shipilev Since your change was applied there have been 49 commits pushed to the master branch:

  • e858dd6: 8267361: JavaTokenizer reads octal numbers mistakenly
  • 1b93b81: 8267133: jdk/jfr/event/gc/collection/TestG1ParallelPhases.java fails with Not expected phases: RestorePreservedMarks, RemoveSelfForwardingPtr: expected true, was false
  • 88b1142: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973
  • 6ef46ce: 8231672: Simplify the reference processing parallelization framework
  • 392f962: 8267151: C2: Don't create dummy Opaque1Node for outmost unswitched IfNode
  • 0cf7e57: 8267239: C1: RangeCheckElimination for % operator if divisor is IntConstant
  • 2d407e1: 8267293: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails when JTREG_JOBS > 25
  • 70f6c67: 8233380: CHT: Node allocation and freeing
  • 2563a6a: 8266962: Add arch supporting check for "Op_VectorLoadConst" before creating the node
  • 4954383: 8267364: Remove mask.incr which is introduced by JDK-8256973
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

Your commit was automatically rebased without conflicts.

Pushed as commit e749f75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8267304-global-768m branch Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated jdk
3 participants