Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267110: Update java.util to use instanceof pattern variable #4088

Closed
wants to merge 6 commits into from

Conversation

@pconcannon
Copy link
Contributor

@pconcannon pconcannon commented May 18, 2021

Hi,

Could someone please review my code for updating the code in the java.util package to make use of the instanceof pattern variable?

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267110: Update java.util to use instanceof pattern variable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4088/head:pull/4088
$ git checkout pull/4088

Update a local copy of the PR:
$ git checkout pull/4088
$ git pull https://git.openjdk.java.net/jdk pull/4088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4088

View PR using the GUI difftool:
$ git pr show -t 4088

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4088.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 18, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@pconcannon The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 18, 2021

Loading

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Changes look good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267110: Update java.util to use instanceof pattern variable

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 18, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented May 18, 2021

You may need to coordinate with @DougLea on the changes to j.u.concurrent.

Loading

@DougLea
Copy link
Contributor

@DougLea DougLea commented May 18, 2021

Because we still make jdk11-compatible test-release java.util.concurrent jars, we are not big fans of adding non-essential differences to openjdk version. But if there is some advantage to doing this, we'll cope.

Loading

naotoj
naotoj approved these changes May 18, 2021
Copy link
Member

@naotoj naotoj left a comment

Classes in the i18n area look good.

Loading

@pconcannon
Copy link
Contributor Author

@pconcannon pconcannon commented May 25, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@pconcannon Since your change was applied there have been 20 commits pushed to the master branch:

  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
  • b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
  • 461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
  • de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/f4531661b55458554f907ba988eca22b72c72bf3...master

Your commit was automatically rebased without conflicts.

Pushed as commit a52c4ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants