8250840: some tests use --enable-preview unnecessarily #41
Conversation
|
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
|
@lahodaj The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
|
/test |
|
/test |
|
Could not create test job |
| @@ -34,7 +34,7 @@ | |||
| * jdk.compiler/com.sun.tools.javac.util | |||
| * @build toolbox.ToolBox toolbox.JavacTask | |||
| * @build combo.ComboTestHelper | |||
| * @compile --enable-preview -source ${jdk.version} ConditionalExpressionResolvePending.java | |||
| * @compile ConditionalExpressionResolvePending.java | |||
| * @run main/othervm --enable-preview ConditionalExpressionResolvePending | |||
There was a problem hiding this comment.
do you still need the @run main/othervm?
There was a problem hiding this comment.
Yes, that's still needed. The test internally compiles some code with --enable-preview and then tries to load and run the code in a separate ClassLoader in the same VM. So --enable-preview at runtime is required.
There was a problem hiding this comment.
ok looks good
|
@lahodaj This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 35 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
|
/test |
|
A test job has been started with id: github.com-149121954-41-689038526 |
|
/integrate |
openjdk
bot
added
integrated
|
@lahodaj Since your change was applied there have been 35 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c98417e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
* CodeElement.Kind moved to Opcode.Kind * removed CodeElement::codeKind * CodeElement::opcode and sizeInBytes moved to Instruction * removed all pseudo Opcodes and Kinds * removed opcode and sizeInBytes from all pseudo instructions and code attributes * split of impl.AbstractInstruction * Wide Opcodes constants fixed
* CodeElement.Kind moved to Opcode.Kind * removed CodeElement::codeKind * CodeElement::opcode and sizeInBytes moved to Instruction * removed all pseudo Opcodes and Kinds * removed opcode and sizeInBytes from all pseudo instructions and code attributes * split of impl.AbstractInstruction * Wide Opcodes constants fixed
* Refactor insert_mem_bar in do_exits. This patch uses the allocation state from _exits, so it will emit Release MemBars for all aliases of obj. This patch also fixed bugs found in CTW java.base module. * Clone MemBarRelease if the orignal checkCastPP is associated with MemBarRelease. It is inserted at the exit of <init>. It's possible that we materialize an object after <init>, we may miss the change to emit MemBarRelease. clone it. * Don't set _is_allocation_MemBar_redundant for the cloned objects. JDK-8144993 subsumes storestore barrier inserted by ME::expand_initialize_membar. This patch avoid from applying this optimization. --------- Co-authored-by: Xin Liu <xxinliu@amazon.com>
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/41/head:pull/41$ git checkout pull/41