Skip to content

8253822: Remove unused exception_address_is_unpack_entry #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

neliasso
Copy link

@neliasso neliasso commented Sep 29, 2020

I have searched the code base without finding any use.

Please review,

Best regards,
Nils


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253822: Remove unused exception_address_is_unpack_entry

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/410/head:pull/410
$ git checkout pull/410

I have searched the code base without finding any use.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2020

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@neliasso The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 29, 2020
@neliasso neliasso changed the title Remove unused exception_address_is_unpack_entry 8253822:Remove unused exception_address_is_unpack_entry Sep 29, 2020
@neliasso neliasso changed the title 8253822:Remove unused exception_address_is_unpack_entry 8253822: Remove unused exception_address_is_unpack_entry Sep 29, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2020

Webrevs

@neliasso
Copy link
Author

/test builds

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

Could not create test job

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253822: Remove unused exception_address_is_unpack_entry

Removing dead code

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 8440279: 8180514: TestPrintMdo.java test fails with -XX:-TieredCompilation
  • 44e6820: 8253650: Cleanup: remove alignment_hint parameter from os::reserve_memory
  • ed62b01: 6646602: Spelling error in javadoc for javax.swing.tree.TreeModel
  • 87276bc: 6690021: typos in TransferHandler Javadoc
  • dd36d8c: 8253429: Error reporting should report correct state of terminated/aborted threads
  • 2d9fa9d: 8247912: Make narrowOop a scoped enum
  • 928da49: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails
  • 3e96721: 8253727: [cgroups v2] Memory and swap limits reported incorrectly
  • 7779ce9: 8253689: [s390] Use flag kind "diagnostic" for platform specific flags
  • a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/2fe0a5d75ee9434017b3df5cfa713ef895a19866...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2020
@neliasso
Copy link
Author

neliasso commented Oct 1, 2020

/summary Removing dead code

@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@neliasso Setting summary to Removing dead code

@neliasso
Copy link
Author

neliasso commented Oct 1, 2020

/integrate

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@neliasso Since your change was applied there have been 43 commits pushed to the master branch:

  • 8440279: 8180514: TestPrintMdo.java test fails with -XX:-TieredCompilation
  • 44e6820: 8253650: Cleanup: remove alignment_hint parameter from os::reserve_memory
  • ed62b01: 6646602: Spelling error in javadoc for javax.swing.tree.TreeModel
  • 87276bc: 6690021: typos in TransferHandler Javadoc
  • dd36d8c: 8253429: Error reporting should report correct state of terminated/aborted threads
  • 2d9fa9d: 8247912: Make narrowOop a scoped enum
  • 928da49: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails
  • 3e96721: 8253727: [cgroups v2] Memory and swap limits reported incorrectly
  • 7779ce9: 8253689: [s390] Use flag kind "diagnostic" for platform specific flags
  • a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/2fe0a5d75ee9434017b3df5cfa713ef895a19866...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9670425.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants