Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267364: Remove mask.incr which is introduced by JDK-8256973 #4107

Closed
wants to merge 1 commit into from

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented May 19, 2021

Hi all,

Please review the trivial change which removes the useless mask.incr.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267364: Remove mask.incr which is introduced by JDK-8256973

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4107/head:pull/4107
$ git checkout pull/4107

Update a local copy of the PR:
$ git checkout pull/4107
$ git pull https://git.openjdk.java.net/jdk pull/4107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4107

View PR using the GUI difftool:
$ git pr show -t 4107

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4107.diff

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented May 19, 2021

/label add hotspot-compiler
/cc hotspot-compiler

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@DamonFool
The hotspot-compiler label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@DamonFool The hotspot-compiler label was already applied.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

Copy link

@iwanowww iwanowww left a comment

Looks good and trivial.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented May 19, 2021

Looks good and trivial.

Thanks @iwanowww .
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267364: Remove mask.incr which is introduced by JDK-8256973

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 19, 2021
@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@DamonFool Pushed as commit 4954383.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented May 19, 2021

Looks good and trivial.

Thanks @TobiHartmann .

@DamonFool DamonFool deleted the JDK-8267364 branch May 19, 2021
@jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented May 19, 2021

Thanks Jie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants