8267396: Avoid recording "pc" in unhandled oops detector for better performance

[shipilev]

See the rationale in the bug.

Additional testing:

• Known slow test with -XX:+CheckUnhandledOops
• tier1 with -XX:+CheckUnhandledOops

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267396: Avoid recording "pc" in unhandled oops detector for better performance

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4114/head:pull/4114
$ git checkout pull/4114

Update a local copy of the PR:
$ git checkout pull/4114
$ git pull https://git.openjdk.java.net/jdk pull/4114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4114

View PR using the GUI difftool:
$ git pr show -t 4114

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4114.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (50cfe20f)

[coleenp]

This is fine. I don't remember why I thought the pc was helpful when I added it. Thanks.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267396: Avoid recording "pc" in unhandled oops detector for better performance

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• 8e3549f: 8266332: Adler32 intrinsic for x86 64-bit platforms
• b961f25: 8267191: Avoid repeated SystemDictionaryShared::should_be_excluded calls
• 74f30ad: 8263684: Avoid wrapping into BufferedWriter twice
• 9820f3d: 8267371: Concurrent gtests take too long
• 38d690b: 8265262: CITime - 'other' incorrectly calculated
• 66ab6d8: 8264181: javadoc tool Incorrect error message about malformed link
• 99fcc41: 8234532: Remove ThreadLocalAllocBuffer::_fast_refill_waste since it is never set
• 237fee8: 8267339: Temporarily disable os.release_multi_mappings_vm on macOS x64
• 64e2479: 8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64
• 9760dba: 8267321: Use switch expression for VarHandle$AccessMode lookup
• ... and 53 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

LGTM2 :)

Thanks,
David

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 75 commits pushed to the master branch:

• 878d1b3: 8267434: Remove LinkOutput[Impl]
• fc7f0a3: 8267480: Explicitly problemlist all runtime/os/TestTracePageSizes.java tests on linux-aarch64 to reduce noise
• 9425d3d: 8261880: Change nested classes in java.base to static nested classes where possible
• 459abd5: 8267219: Javadoc method summary breaks when {@inheritdoc} from an empty parent
• aba2265: 8260267: ZGC: Reduce mark stack usage
• f979523: 8267463: Problemlist runtime/os/TestTracePageSizes.java on linux-aarch64 to reduce noise
• f07dcf4: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
• 31320c3: 8267262: com/sun/net/httpserver/Filter improve API documentation of static methods
• 7dcb9fd: 8265684: implement Sealed Classes as a standard feature in Java, javadoc changes
• 0fa9223: 8260517: implement Sealed Classes as a standard feature in Java
• ... and 65 more: https://git.openjdk.java.net/jdk/compare/f4227879b0504bc4656bd84153b13b04c007aa66...master

Your commit was automatically rebased without conflicts.

Pushed as commit f67847f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.