Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64 #4117

Closed
wants to merge 2 commits into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 19, 2021

A trivial fix to ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64
  • JDK-8267409: ProblemList gc/epsilon/TestClasses.java on linux-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4117/head:pull/4117
$ git checkout pull/4117

Update a local copy of the PR:
$ git checkout pull/4117
$ git pull https://git.openjdk.java.net/jdk pull/4117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4117

View PR using the GUI difftool:
$ git pr show -t 4117

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4117.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented May 19, 2021

/label add hotspot-runtime

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and trivial.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64
8267409: ProblemList gc/epsilon/TestClasses.java on linux-x64

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 19, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented May 19, 2021

/issue JDK-8267407
/issue JDK-8267409

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented May 19, 2021

@tschatzl - I added a second ProblemListing in the same file.
Would you be so kind as to re-review? Thanks!

Loading

@openjdk openjdk bot changed the title 8267407 ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64 8267407: ProblemList vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java on linux-aarch64 May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8267409: ProblemList gc/epsilon/TestClasses.java on linux-x64.

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Still good.

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented May 19, 2021

@tschatzl - Thanks!

/integrate

Loading

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@dcubed-ojdk Pushed as commit 64e2479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Copy link

@gerard-ziemski gerard-ziemski left a comment

Looks good, thanks!

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8267407 branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants